From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH9WV-0002HN-MR for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:14:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH9WR-0001AB-Fm for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:14:03 -0500 Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:58300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH9WR-00019x-6y for qemu-devel@nongnu.org; Fri, 30 Jan 2015 06:13:59 -0500 Received: by mail-we0-f182.google.com with SMTP id l61so26459335wev.13 for ; Fri, 30 Jan 2015 03:13:58 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54CB6773.9020205@redhat.com> Date: Fri, 30 Jan 2015 12:13:55 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno> <20150122085311.5276.90400.stgit@PASHA-ISP.def.inno> In-Reply-To: <20150122085311.5276.90400.stgit@PASHA-ISP.def.inno> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH v8 18/21] replay: thread pool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > - return thread_pool_submit_aio(pool, aio_worker, acb, cb, opaque); > + return thread_pool_submit_aio(pool, aio_worker, acb, cb, opaque, > + qiov ? qiov->replay : false, > + qiov ? qiov->replay_step : 0); Adding the replay/replay_step to the QEMUIOVector is... weird. You're paying for the fact that we do not have a BlockRequest struct that is used throughout. I guess we can live with this until other problems are solved, then we can discuss this with the block folks and go for a more complete solution. Paolo