From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762497AbbA3PYZ (ORCPT ); Fri, 30 Jan 2015 10:24:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51208 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbbA3PYY (ORCPT ); Fri, 30 Jan 2015 10:24:24 -0500 Message-ID: <54CBA21D.6050506@redhat.com> Date: Fri, 30 Jan 2015 16:24:13 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Nadav Amit , Gleb Natapov Subject: Re: [PATCH 0/8] KVM: minor APIC fixes and cleanups References: <1422568135-28402-1-git-send-email-rkrcmar@redhat.com> <54CB4D44.1080109@redhat.com> <20150130152031.GC28519@potion.redhat.com> In-Reply-To: <20150130152031.GC28519@potion.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/2015 16:20, Radim Krčmář wrote: >> > + /* XXX: A superset of x2APIC broadcasts is fine in practice as long as >> > + * we don't support APIC ID > 0xfeffffff. >> > + */ >> > >> > It's ugly. :) > Yeah, there is: don't deliver x2APIC broadcasts to xAPIC. > (I'm not even sure if it is correct ...) > > Without that delivery, we could do something like > if (irq->dest_id == (x2apic_ipi ? X2APIC_BROADCAST : APIC_BROADCAST)) Nadav, do you know what real hardware does? Paolo