From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [PATCH v10 1/2] librte_net: add crc compute APIs
Date: Wed, 5 Apr 2017 19:22:42 +0000
Message-ID: <54CBAA185211B4429112C315DA58FF6D31B49B72@IRSMSX103.ger.corp.intel.com>
References: <1490890533-92231-2-git-send-email-jasvinder.singh@intel.com>
 <1491404326-89256-1-git-send-email-jasvinder.singh@intel.com>
 <1491404326-89256-2-git-send-email-jasvinder.singh@intel.com>
 <1806652.2aVc4LrPS0@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "olivier.matz@6wind.com"
 <olivier.matz@6wind.com>, "Doherty, Declan" <declan.doherty@intel.com>, "De
 Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 3CD941DB1
 for <dev@dpdk.org>; Wed,  5 Apr 2017 21:22:45 +0200 (CEST)
In-Reply-To: <1806652.2aVc4LrPS0@xps13>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, April 5, 2017 6:50 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org; olivier.matz@6wind.com; Doherty, Declan
> <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v10 1/2] librte_net: add crc compute APIs
>=20
> 2017-04-05 15:58, Jasvinder Singh:
> > APIs for selecting the architecure specific implementation and
> > computing the crc (16-bit and 32-bit CRCs) are added. For CRCs
> > calculation, scalar as well as x86 intrinsic(sse4.2) versions are imple=
mented.
> >
> > The scalar version is based on generic Look-Up Table(LUT) algorithm,
> > while x86 intrinsic version uses carry-less multiplication for fast
> > CRC computation.
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>=20
> There is a remaining error with doxygen:
> 	lib/librte_net/rte_net_crc_sse.h:153:
> 	warning: documented symbol `static const uint8_t
> crc_xmm_shift_tab'
> 	was not declared or defined.
>=20
> > --- a/lib/librte_net/Makefile
> > +++ b/lib/librte_net/Makefile
> > @@ -39,10 +39,12 @@ EXPORT_MAP :=3D rte_net_version.map  LIBABIVER
> :=3D 1
> >
> >  SRCS-$(CONFIG_RTE_LIBRTE_NET) :=3D rte_net.c
> > +SRCS-$(CONFIG_RTE_LIBRTE_NET) +=3D rte_net_crc.c
> >
> >  # install includes
> >  SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include :=3D rte_ip.h rte_tcp.h
> > rte_udp.h  SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include +=3D rte_sctp.h
> > rte_icmp.h rte_arp.h  SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include +=3D
> > rte_ether.h rte_gre.h rte_net.h
> > +SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include +=3D rte_net_crc.h
>=20
> As rte_net_crc_sse.h is not exported, you should avoid doxygen generation=
.
> I suggest removing the rte_ prefix of the filename, so it will make clear=
 that it
> is a private header and doxygen should ignore it (because of FILE_PATTERN=
S
> =3D rte_*.h).

Thanks, will fix above in next version.