All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH] examples/ip_pipeline: fix logically dead node
Date: Wed, 18 Apr 2018 14:03:27 +0000	[thread overview]
Message-ID: <54CBAA185211B4429112C315DA58FF6D33340886@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20180416105820.66064-1-roy.fan.zhang@intel.com>



> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:58 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix logically dead node
> 
> Coverity issue: 272567
> Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/ip_pipeline/cli.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index
> 199a31ff8..6c07ca223 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -1890,12 +1890,6 @@ cmd_pipeline_table(char **tokens,
> 
>  		t0 += 6;
>  	} else if (strcmp(tokens[t0], "stub") == 0) {
> -		if (n_tokens < t0 + 1) {
> -			snprintf(out, out_size, MSG_ARG_MISMATCH,
> -				"pipeline table stub");
> -			return;
> -		}
> -
>  		p.match_type = TABLE_STUB;
> 
>  		t0 += 1;
> --
> 2.13.6

Reviewed-by: Jasvinder Singh <jasvindeer.singh@intel.com>

  reply	other threads:[~2018-04-18 14:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 10:58 [PATCH] examples/ip_pipeline: fix logically dead node Fan Zhang
2018-04-18 14:03 ` Singh, Jasvinder [this message]
2018-05-08 14:28 ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CBAA185211B4429112C315DA58FF6D33340886@IRSMSX101.ger.corp.intel.com \
    --to=jasvinder.singh@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.