From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762764AbbA3RF0 (ORCPT ); Fri, 30 Jan 2015 12:05:26 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:63160 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752740AbbA3RFY (ORCPT ); Fri, 30 Jan 2015 12:05:24 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-92-54cbb93ff01b Message-id: <54CBB9C9.3060500@samsung.com> Date: Fri, 30 Jan 2015 20:05:13 +0300 From: Andrey Ryabinin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Dmitry Vyukov , Konstantin Serebryany , Dmitry Chernenkov , Andrey Konovalov , Yuri Gribov , Konstantin Khlebnikov , Sasha Levin , Christoph Lameter , Joonsoo Kim , Dave Hansen , Andi Kleen , x86@kernel.org, linux-mm@kvack.org, Pekka Enberg , David Rientjes Subject: Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable() References: <1404905415-9046-1-git-send-email-a.ryabinin@samsung.com> <1422544321-24232-1-git-send-email-a.ryabinin@samsung.com> <1422544321-24232-7-git-send-email-a.ryabinin@samsung.com> <20150129151243.fd76aca21757b1ca5b62163e@linux-foundation.org> In-reply-to: <20150129151243.fd76aca21757b1ca5b62163e@linux-foundation.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42I5/e/4ZV37nadDDFrOyVr83juT1WLO+jVs FkeufWe3uP7tDaPFp5cPGC2eP3zIbjHhYRu7xcruZjaL7c/eMlms7HzAanF51xw2i3tr/rNa tH3+BySWbGSyWHzkNrPFu2eTmS1+bHjM6iDoMX/nR0aPnbPusnss2FTqsXjPSyaPTas62Tw2 fZrE7tH19gqTx4kZv1k8nlyZzuTx8ektFo/Pm+QCuKO4bFJSczLLUov07RK4Mv50HGUpuMxZ MXPhCqYGxhfsXYycHBICJhJP5s5nhLDFJC7cW88GYgsJLGWUaPns0MXIBWQ3M0m8u3sArIFX QEuia9duZhCbRUBV4kfTeTCbTUBP4t+s7WDNogIREh9WfWWDqBeU+DH5HguILSKgK7Hq+S5m kKHMAjtYJLYdnwQ2VFggXaLx1U5GiG0NTBKfnvWDJTgFvIGKLgNN4gDq0JO4f1ELJMwsIC+x ec1b5gmMArOQ7JiFUDULSdUCRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCEx+HUH49Jj VocYBTgYlXh4bySeDhFiTSwrrsw9xCjBwawkwjtlElCINyWxsiq1KD++qDQntfgQIxMHp1QD Y2tnTH7IpmnfXx6p0d7XlbLj+D4dtQ99Hrqhyl1Hiuo8xAOMLSo11afaXolfGPdb90UWN7uL 8cx/HW5az4y+3ynYv+2OUPver60KH40f/0yY+i1JOU5u391/Lu9+v/rh6V+17pEb/+494l2V evs4p9tvMFI9nndhxXaTl12f783e5u/m5f1XTomlOCPRUIu5qDgRAE2tp/GfAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/2015 02:12 AM, Andrew Morton wrote: > On Thu, 29 Jan 2015 18:11:50 +0300 Andrey Ryabinin wrote: > >> Wrap access to object's metadata in external functions with >> metadata_access_enable()/metadata_access_disable() function calls. >> >> This hooks separates payload accesses from metadata accesses >> which might be useful for different checkers (e.g. KASan). >> >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -467,13 +467,23 @@ static int slub_debug; >> static char *slub_debug_slabs; >> static int disable_higher_order_debug; >> >> +static inline void metadata_access_enable(void) >> +{ >> +} >> + >> +static inline void metadata_access_disable(void) >> +{ >> +} > > Some code comments here would be useful. What they do, why they exist, > etc. The next patch fills them in with > kasan_disable_local/kasan_enable_local but that doesn't help the reader > to understand what's going on. The fact that > kasan_disable_local/kasan_enable_local are also undocumented doesn't > help. > Ok, How about this? /* * This hooks separate payload access from metadata access. * Useful for memory checkers that have to know when slub * accesses metadata. */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by kanga.kvack.org (Postfix) with ESMTP id 247426B0032 for ; Fri, 30 Jan 2015 12:05:27 -0500 (EST) Received: by mail-pa0-f46.google.com with SMTP id lj1so54421125pab.5 for ; Fri, 30 Jan 2015 09:05:26 -0800 (PST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com. [210.118.77.12]) by mx.google.com with ESMTPS id ht1si14364101pac.134.2015.01.30.09.05.25 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Fri, 30 Jan 2015 09:05:26 -0800 (PST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJ00031I2BOK3B0@mailout2.w1.samsung.com> for linux-mm@kvack.org; Fri, 30 Jan 2015 17:09:24 +0000 (GMT) Message-id: <54CBB9C9.3060500@samsung.com> Date: Fri, 30 Jan 2015 20:05:13 +0300 From: Andrey Ryabinin MIME-version: 1.0 Subject: Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable() References: <1404905415-9046-1-git-send-email-a.ryabinin@samsung.com> <1422544321-24232-1-git-send-email-a.ryabinin@samsung.com> <1422544321-24232-7-git-send-email-a.ryabinin@samsung.com> <20150129151243.fd76aca21757b1ca5b62163e@linux-foundation.org> In-reply-to: <20150129151243.fd76aca21757b1ca5b62163e@linux-foundation.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Dmitry Vyukov , Konstantin Serebryany , Dmitry Chernenkov , Andrey Konovalov , Yuri Gribov , Konstantin Khlebnikov , Sasha Levin , Christoph Lameter , Joonsoo Kim , Dave Hansen , Andi Kleen , x86@kernel.org, linux-mm@kvack.org, Pekka Enberg , David Rientjes On 01/30/2015 02:12 AM, Andrew Morton wrote: > On Thu, 29 Jan 2015 18:11:50 +0300 Andrey Ryabinin wrote: > >> Wrap access to object's metadata in external functions with >> metadata_access_enable()/metadata_access_disable() function calls. >> >> This hooks separates payload accesses from metadata accesses >> which might be useful for different checkers (e.g. KASan). >> >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -467,13 +467,23 @@ static int slub_debug; >> static char *slub_debug_slabs; >> static int disable_higher_order_debug; >> >> +static inline void metadata_access_enable(void) >> +{ >> +} >> + >> +static inline void metadata_access_disable(void) >> +{ >> +} > > Some code comments here would be useful. What they do, why they exist, > etc. The next patch fills them in with > kasan_disable_local/kasan_enable_local but that doesn't help the reader > to understand what's going on. The fact that > kasan_disable_local/kasan_enable_local are also undocumented doesn't > help. > Ok, How about this? /* * This hooks separate payload access from metadata access. * Useful for memory checkers that have to know when slub * accesses metadata. */ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org