From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 12/20] testpmd: introduce parse_vxlan in csum
	fwd engine
Date: Mon, 02 Feb 2015 13:42:01 +0100
Message-ID: <54CF7099.8070006@6wind.com>
References: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com>
 <1422623775-8050-1-git-send-email-olivier.matz@6wind.com>
 <1422623775-8050-13-git-send-email-olivier.matz@6wind.com>
 <1ED644BD7E0A5F4091CF203DAFB8E4CC01DC963B@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: "Liu, Jijiang" <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01DC963B-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Jijiang,

On 02/02/2015 02:49 AM, Liu, Jijiang wrote:
>> +/* Parse a vxlan header */
>> +static void
>> +parse_vxlan(struct udp_hdr *udp_hdr, struct testpmd_offload_info *info,
>> +	uint64_t mbuf_olflags)
>> +{
>> +	struct ether_hdr *eth_hdr;
>> +
>> +	/* check udp destination port, 4789 is the default vxlan port
>> +	 * (rfc7348) or that the rx offload flag is set (i40e only
>> +	 * currently) */
>> +	if (udp_hdr->dst_port != _htons(4789) &&
>> +		(mbuf_olflags & (PKT_RX_TUNNEL_IPV4_HDR |
>> +			PKT_RX_TUNNEL_IPV6_HDR)) != 0)
> 
> It seems that there is a bug, which is mbuf_olflags check.
> It should be 
> (mbuf_olflags & (PKT_RX_TUNNEL_IPV4_HDR |
> 			PKT_RX_TUNNEL_IPV6_HDR)) == 0).

That's correct. Thank you for checking this carefully. I'll
fix this in a v2 patch.

Regards,
Olivier