From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1YIKzr-0006es-7l
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 12:41:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1YIKzj-0008Ra-UP
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 12:41:15 -0500
Received: from relay.parallels.com ([195.214.232.42]:42493)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1YIKzj-0008Mu-LG
	for qemu-devel@nongnu.org; Mon, 02 Feb 2015 12:41:07 -0500
Message-ID: <54CFB6AB.9060902@parallels.com>
Date: Mon, 2 Feb 2015 20:40:59 +0300
From: "Denis V. Lunev" <den-lists@parallels.com>
MIME-Version: 1.0
References: <1422888514-6495-1-git-send-email-pl@kamp.de>	<20150202161332.GK9478@noname.redhat.com>	<54CFA4DE.702@openvz.org>	<20150202164503.GA19586@noname.redhat.com>	<54CFAD15.6080702@openvz.org>
	<54CFB529.7050802@redhat.com>
In-Reply-To: <54CFB529.7050802@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block: change default for discard and
 write zeroes to INT_MAX
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, "Denis V. Lunev" <den@openvz.org>, Kevin Wolf <kwolf@redhat.com>
Cc: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org

On 02/02/15 20:34, Paolo Bonzini wrote:
>
>
> On 02/02/2015 18:00, Denis V. Lunev wrote:
>>>
>> You are absolutely correct for NBD case but I do not get the
>> point about SIZE_MAX for gluster. There is no such definition
>> in their git at git://github.com/gluster/glusterfs nor in
>> public API headers in Ubuntu :(
>
> SIZE_MAX is defined in stdint.h (provided by the C library).
>
> Paolo
>
In this case the code should avoid overflow on 64bit arch.

OK, re-spinning.