From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933014AbbBBSk1 (ORCPT ); Mon, 2 Feb 2015 13:40:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33145 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932629AbbBBSk0 (ORCPT ); Mon, 2 Feb 2015 13:40:26 -0500 Message-ID: <54CFC486.7080403@redhat.com> Date: Mon, 02 Feb 2015 13:40:06 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Oleg Nesterov CC: dave.hansen@linux.intel.com, sbsiddha@gmail.com, luto@amacapital.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, fenghua.yu@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] x86,fpu: remove redundant increments of fpu_counter References: <20150129210723.GA31584@redhat.com> <1422900051-10778-1-git-send-email-riel@redhat.com> <1422900051-10778-7-git-send-email-riel@redhat.com> <20150202183418.GA16547@redhat.com> In-Reply-To: <20150202183418.GA16547@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/02/2015 01:34 PM, Oleg Nesterov wrote: > On 02/02, riel@redhat.com wrote: >> >> From: Rik van Riel >> >> fpu.preload only gets set if new->thread.fpu_counter is already >> larger than 5. Incrementing it further does absolutely nothing. >> Remove those lines. > > I _think_ that we increment it further on purpose. Note that > fpu_counter is "char", so it seems that we want no more than 256 > automatic preloads. > > So I am not sure about this change. At least the changelog doesn't > look right. You are right, lets drop this patch 6/6. Do the other five look right? - -- All rights reversed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUz8SFAAoJEM553pKExN6DQOcH/1+BrG+jIItcfZG3KwnN3Dfv nXtmlNRiopMTJQ3HxzYEBT40zuqnKDSsf2cvMkcVJjt3oUukbD8D22iyJQzQxKnZ g1MSJmZzSFZ1D0hoI/Qv3OLjyYJtcI4BaTHvs8f/YSmovTLY9D3e4zD37RbQp2d4 S0PdX/xxJBHpdJtFNaQni1VE9isIPh5x0YK8T55t5WhwRM+JwH+8C3mlL28ZEyQl +BclNypHDiFKct+TL9NK+2RBRC2qwjuZzLi0BVrF49yK8G+Zw+8026vGrUOnx6Gg XICJbyZbkBtn2J7Mc8i2xT2U4fYUy6pjcNuh0OiDSCV1f47iznBN0MjRwzc8ugo= =mOwp -----END PGP SIGNATURE-----