From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIN1Y-0000e8-Ux for qemu-devel@nongnu.org; Mon, 02 Feb 2015 14:51:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIN1Y-0001Vx-5N for qemu-devel@nongnu.org; Mon, 02 Feb 2015 14:51:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIN1X-0001Vl-V5 for qemu-devel@nongnu.org; Mon, 02 Feb 2015 14:51:08 -0500 Message-ID: <54CFD527.3010308@redhat.com> Date: Mon, 02 Feb 2015 14:51:03 -0500 From: Max Reitz MIME-Version: 1.0 References: <1422284444-12529-1-git-send-email-mreitz@redhat.com> <1422284444-12529-10-git-send-email-mreitz@redhat.com> <20150202193402.GE19586@noname.redhat.com> In-Reply-To: <20150202193402.GE19586@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 09/14] qemu-io: Use blk_new_open() in openfile() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefano Stabellini , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster On 2015-02-02 at 14:34, Kevin Wolf wrote: > Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: >> Signed-off-by: Max Reitz >> --- >> qemu-io.c | 31 ++++++++++++------------------- >> 1 file changed, 12 insertions(+), 19 deletions(-) >> >> diff --git a/qemu-io.c b/qemu-io.c >> index 91a445a..81f8f64 100644 >> --- a/qemu-io.c >> +++ b/qemu-io.c >> @@ -39,7 +39,6 @@ static ReadLineState *readline_state; >> static int close_f(BlockDriverState *bs, int argc, char **argv) >> { >> blk_unref(qemuio_blk); >> - qemuio_bs = NULL; >> qemuio_blk = NULL; >> return 0; >> } > This doesn't seem to be correct at this point in the series. qemuio_bs > is still passed to qemuio_command(), which checks whether non-global > commands are allowed to run using init_check_command(). $ ./qemu-io -c close -c 'read 0 64k' test.qcow2 read failed: No medium found Yep, will fix. Thanks for catching it! > At the end of the series, please remove qemuio_bs altogether. This > version of the series leaves it around without any reader. Okay, will do. Max