From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIZHE-00017H-99 for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:56:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIZHB-0007WD-2S for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:56:08 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:12589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIZHA-0007Ve-Et for qemu-devel@nongnu.org; Tue, 03 Feb 2015 03:56:05 -0500 Message-ID: <54D08D09.9040509@huawei.com> Date: Tue, 3 Feb 2015 16:55:37 +0800 From: Gonglei MIME-Version: 1.0 References: <1422515335-13316-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1422515335-13316-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/5] vhost-scsi: support to assign boot order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "Huangweidong (C)" , "Subo (A)" , "mst@redhat.com" , "qemu-devel@nongnu.org" , "Huangpeng (Peter)" , "pbonzini@redhat.com" On 2015/1/29 15:08, Gonglei (Arei) wrote: > From: Gonglei > > Qemu haven't provide a bootindex property for vhost-scsi device. > So, we can not assign the boot order for it at present. But > Some clients/users have requirements for that in some scenarios. > This patch achieve the aim in Qemu side. > > Because Qemu only accept an wwpn argument for vhost-scsi, we > cannot assign a tpgt. That's say tpg is transparent for Qemu, Qemu > doesn't know which tpg can boot, but vhost-scsi driver module > doesn't know too for one assigned wwpn. > > At present, we assume that the first tpg can boot only, and add > a boot_tpgt property that defaults to 0. Of course, people can > pass a valid value by qemu command line. > Ping... > v2 -> v1: (Thanks to Paolo's suggestion) > - change calling qdev_get_own_fw_dev_path_from_handler in > get_boot_devices_list, and convert non-NULL suffixes to > implementations of FWPathProvider in Patch 1. (Paolo) > - add a boot_tpgt property for vhost-scsi in Patch 4. (Paolo) > - remove the ioctl calling in Patch 4, because the kernel > patch hasn't been accepted. > > kernel patch: > [PATCH] vhost-scsi: introduce an ioctl to get the minimum tpgt > http://news.gmane.org/gmane.comp.emulators.kvm.devel > > Gonglei (5): > qdev: support to get a device firmware path directly > vhost-scsi: add bootindex property > vhost-scsi: realize the TYPE_FW_PATH_PROVIDER interface > vhost-scsi: add a property for booting > vhost-scsi: set the bootable value of channel/target/lun > > bootdevice.c | 31 +++++++++++++++++-------------- > hw/core/qdev.c | 7 +++++++ > hw/scsi/vhost-scsi.c | 35 +++++++++++++++++++++++++++++++++++ > hw/virtio/virtio-pci.c | 2 ++ > include/hw/qdev-core.h | 1 + > include/hw/virtio/vhost-scsi.h | 5 +++++ > include/hw/virtio/virtio-scsi.h | 1 + > 7 files changed, 68 insertions(+), 14 deletions(-) >