From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures Date: Tue, 03 Feb 2015 09:17:32 +0000 Message-ID: <54D0A03C020000780005C426@mail.emea.novell.com> References: <1422567998-29995-1-git-send-email-tamas.lengyel@zentific.com> <1422567998-29995-2-git-send-email-tamas.lengyel@zentific.com> <1422897588.8023.5.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422897588.8023.5.camel@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Tamas K Lengyel Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, rcojocaru@bitdefender.com, stefano.stabellini@eu.citrix.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, steve@zentific.com, andres@lagarcavilla.org, jun.nakajima@intel.com, rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov, yanghy@cn.fujitsu.com List-Id: xen-devel@lists.xenproject.org >>> On 02.02.15 at 18:19, wrote: > On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote: >> + union { >> + struct mem_event_paging_data mem_paging; >> + struct mem_event_sharing_data mem_sharing; >> + struct mem_event_mem_access_data mem_access; >> + struct mem_event_mov_to_cr_data mov_to_cr; >> + struct mem_event_mov_to_msr_data mov_to_msr; >> + struct mem_event_software_breakpoint_data software_breakpoint; >> + struct mem_event_singlestep_data singlestep; >> + } data; > > We typically call these unions "u" but that's up to the hypervisor guys > really. And yes, I agree we should be consistent with things like this. Jan