From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIgWr-0001sn-3M for qemu-devel@nongnu.org; Tue, 03 Feb 2015 11:40:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIgWn-0005eQ-Mw for qemu-devel@nongnu.org; Tue, 03 Feb 2015 11:40:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIgWn-0005eH-42 for qemu-devel@nongnu.org; Tue, 03 Feb 2015 11:40:41 -0500 Message-ID: <54D0FA00.4090303@redhat.com> Date: Tue, 03 Feb 2015 09:40:32 -0700 From: Eric Blake MIME-Version: 1.0 References: <1421913839-22448-1-git-send-email-sfeldma@gmail.com> <1421913839-22448-4-git-send-email-sfeldma@gmail.com> In-Reply-To: <1421913839-22448-4-git-send-email-sfeldma@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HqV8php1aAkPeHGtMtUomNiEHP94tgMCP" Subject: Re: [Qemu-devel] [PATCH v5 03/10] rocker: add register programming guide List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com, qemu-devel@nongnu.org, jiri@resnulli.us, roopa@cumulusnetworks.com, john.fastabend@gmail.com, pbonzini@redhat.com, stefanha@gmail.com, dsahern@gmail.com, jasowang@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HqV8php1aAkPeHGtMtUomNiEHP94tgMCP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/22/2015 01:03 AM, sfeldma@gmail.com wrote: > From: Scott Feldman >=20 > This is the register programming guide for the Rocker device. It's int= ended > for driver writers and device writers. It covers the device's PCI spac= e, > the register set, DMA interface, and interrupts. >=20 In addition to typos already pointed out by Stefan, > + > +Writing BASE_ADDR or SIZE will reset HEAD and TAIL to zero. HEAD cann= ot be > +written passed TAIL. To do so would wrap the ring. An empty ring is = when HEAD s/passed/past/ > + > +To support forward- and backward-compatibility, descriptor and complet= ion > +payloads are specified in TLV format. Fields are packed with Type=3Df= ield name, > +Length=3Dfield length, and Value=3Dfield value. Software will ignore = unknown fields > +filled in by the switch. Likewise, the switch will ignore unknown fie= lds > +filled in by software. Is ignoring unknown fields always the wisest action? If the unknown fields are supposed to have an impact according the to writer, but get ignored by the reader, then the two can get out of sync with what they assume the other end is doing. > +MSI-X vectors used for descriptor ring completions use a credit mechan= ism for > +efficient device, PCIe bus, OS and driver operations. Each descriptor= ring has > +a credit count which represent the number of outstanding descriptors t= o be s/represent/represents/ > + > + port mapping > + ------------------------------------------------------- > + 0 CPU port (for packets to/from host CPU) > + 1-62 front-panel physical ports > + 63 loopback port > + 64-0x0000ffff RSVD > + 0x00010000-0x0001ffff logical tunnel ports > + 0x00020000-0xffffffff RSVD Alignment looks off. > +Port Settings > +------------- > + > +Links status for all front-panel ports is available via PORT_PHYS_LINK= _STATUS: s/Links/Link/ > + > + DESC_COMP_ERR reason > + -------------------------------------------------------------------- > + 0 OK > + -ROCKER_ENXIO address or data read err on desc buf > + -ROCKER_ENOMEM no memory for internal staging desc buf > + -ROCKER_EMSGSIZE Rx descriptor buffer wasn't big enough to contain > + pactet data TLV and other TLVs. s/pactet/packet/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HqV8php1aAkPeHGtMtUomNiEHP94tgMCP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU0PoAAAoJEKeha0olJ0NqRjQH/iBvdh81qRCJZWzIm1BlYbpx +BLWwzFgHkEscXcdhxUS5K8iA3ZLTwRFeLkVIVasRZ3izYMArCXg9rabRAdvv6zd i46VWOebxl4vn5lpCsUbGlRE8VsHKNJzKNe/ePOecnSrwqKTNcPT1VQThinUS3Ih FeFnUNRJFBqRrUkHQ06TPktDPBEACMrelxck9DlUKLskMJNNVPODpQ+MU71Dyey0 xE9Ety6pm7NtXH65TW3XhPyS5kr/+0pxOMgXSyP4pcPLhejv61GjeR6eZFqf5ZXQ g0qmsEY+g9Xvcn1N3gAkF2d7wLoqIChQhd9R44cQ63Vaqe9p07ECTBQg/1rQBNs= =xCHa -----END PGP SIGNATURE----- --HqV8php1aAkPeHGtMtUomNiEHP94tgMCP--