From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [RFC PATCH V3 03/12] xen/mem_paging: Convert
 mem_event_op to mem_paging_op
Date: Tue, 03 Feb 2015 15:41:26 +0000
Message-ID: <54D0FA36020000780005C759@mail.emea.novell.com>
References: <1422567998-29995-1-git-send-email-tamas.lengyel@zentific.com>
	<1422567998-29995-4-git-send-email-tamas.lengyel@zentific.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1422567998-29995-4-git-send-email-tamas.lengyel@zentific.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, rcojocaru@bitdefender.com, stefano.stabellini@eu.citrix.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, steve@zentific.com, andres@lagarcavilla.org, jun.nakajima@intel.com, rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov, yanghy@cn.fujitsu.com
List-Id: xen-devel@lists.xenproject.org

>>> On 29.01.15 at 22:46, <tamas.lengyel@zentific.com> wrote:
> --- a/xen/arch/x86/mm/mem_paging.c
> +++ b/xen/arch/x86/mm/mem_paging.c
> @@ -25,31 +25,29 @@
>  #include <xen/mem_event.h>
>  
>  
> -int mem_paging_memop(struct domain *d, xen_mem_event_op_t *mec)
> +int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *mpc)
>  {
>      if ( unlikely(!d->mem_event->paging.ring_page) )
>          return -ENODEV;
>  
> -    switch( mec->op )
> +    switch( mpc->op )
>      {
>      case XENMEM_paging_op_nominate:
>      {
> -        unsigned long gfn = mec->gfn;
> -        return p2m_mem_paging_nominate(d, gfn);
> +        return p2m_mem_paging_nominate(d, mpc->gfn);
>      }
>      break;
>  
>      case XENMEM_paging_op_evict:
>      {
> -        unsigned long gfn = mec->gfn;
> -        return p2m_mem_paging_evict(d, gfn);
> +        return p2m_mem_paging_evict(d, mpc->gfn);
>      }
>      break;
>  
>      case XENMEM_paging_op_prep:
>      {
> -        unsigned long gfn = mec->gfn;
> -        return p2m_mem_paging_prep(d, gfn, mec->buffer);
> +        unsigned long gfn = mpc->gfn;
> +        return p2m_mem_paging_prep(d, gfn, mpc->buffer);
>      }

So you nicely dropped the pointless local variables above, but not
here? Why? Also, where you drop them, please also drop the then
pointless figure braces.

> --- a/xen/arch/x86/x86_64/compat/mm.c
> +++ b/xen/arch/x86/x86_64/compat/mm.c
> @@ -188,11 +188,11 @@ int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>  
>      case XENMEM_paging_op:
>      {
> -        xen_mem_event_op_t meo;
> -        if ( copy_from_guest(&meo, arg, 1) )
> +        xen_mem_paging_op_t mpo;
> +        if ( copy_from_guest(&mpo, arg, 1) )

Please fix coding style issues in code you touch anyway: Here,
insert a blank line between declaration and first statement.

Jan