From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38353)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YJNwE-00012u-6D
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:01:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YJNwA-00080I-7y
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:01:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59255)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YJNw9-00080C-W4
	for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:01:46 -0500
Message-ID: <54D385CD.4080101@redhat.com>
Date: Thu, 05 Feb 2015 17:01:33 +0200
From: Marcel Apfelbaum <marcel@redhat.com>
MIME-Version: 1.0
References: <1421938231-25698-1-git-send-email-imammedo@redhat.com>
	<1421938231-25698-6-git-send-email-imammedo@redhat.com>
In-Reply-To: <1421938231-25698-6-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 05/47] acpi: add acpi_if() term
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, drjones@redhat.com, marcel.a@redhat.com, claudio.fontana@huawei.com, mst@redhat.com

On 01/22/2015 04:49 PM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>   hw/acpi/acpi-build-utils.c         | 8 ++++++++
>   include/hw/acpi/acpi-build-utils.h | 1 +
>   2 files changed, 9 insertions(+)
>
> diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c
> index d0b0159..40a1769 100644
> --- a/hw/acpi/acpi-build-utils.c
> +++ b/hw/acpi/acpi-build-utils.c
> @@ -314,6 +314,14 @@ static AcpiAml aml_allocate_internal(uint8_t op, AcpiBlockFlags flags)
>       return var;
>   }
>
> +/* ACPI 5.0: 20.2.5.3 Type 1 Opcodes Encoding: DefIfElse */
> +AcpiAml acpi_if(AcpiAml predicate)
> +{
> +    AcpiAml var = aml_allocate_internal(0xA0 /* IfOp */, PACKAGE);
> +    aml_append(&var, predicate);
> +    return var;
> +}
There are other ACPI constructs exactly like the above, except
the operation number (0xA0).
Maybe we can have a generic internal function and the API
will call it.

For example IfWhile has the same structure except the op number,
and maybe many other Type 1 Opcodes.

Thanks,
Marcel

> +
>   /* ACPI 5.0: 20.2.5.2 Named Objects Encoding: DefMethod */
>   AcpiAml acpi_method(const char *name, int arg_count)
>   {
> diff --git a/include/hw/acpi/acpi-build-utils.h b/include/hw/acpi/acpi-build-utils.h
> index 19ebc2d..177f9ed 100644
> --- a/include/hw/acpi/acpi-build-utils.h
> +++ b/include/hw/acpi/acpi-build-utils.h
> @@ -22,6 +22,7 @@ typedef struct AcpiAml {
>   void aml_append(AcpiAml *parent_ctx, AcpiAml child);
>
>   /* Block ASL object primitives */
> +AcpiAml acpi_if(AcpiAml predicate);
>   AcpiAml acpi_method(const char *name, int arg_count);
>   AcpiAml GCC_FMT_ATTR(1, 2) acpi_scope(const char *name_format, ...);
>   AcpiAml GCC_FMT_ATTR(1, 2) acpi_device(const char *name_format, ...);
>