From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJODh-0003kp-1n for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:19:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJODc-00029Q-2P for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:19:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJODb-00029G-Qm for qemu-devel@nongnu.org; Thu, 05 Feb 2015 10:19:48 -0500 Message-ID: <54D38A0B.7080606@redhat.com> Date: Thu, 05 Feb 2015 17:19:39 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1421938231-25698-1-git-send-email-imammedo@redhat.com> <1421938231-25698-23-git-send-email-imammedo@redhat.com> In-Reply-To: <1421938231-25698-23-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 22/47] acpi: add acpi_io() helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, drjones@redhat.com, marcel.a@redhat.com, claudio.fontana@huawei.com, mst@redhat.com On 01/22/2015 04:50 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/acpi-build-utils.c | 19 +++++++++++++++++++ > include/hw/acpi/acpi-build-utils.h | 7 +++++++ > 2 files changed, 26 insertions(+) > > diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c > index 32a4377..56b237a 100644 > --- a/hw/acpi/acpi-build-utils.c > +++ b/hw/acpi/acpi-build-utils.c > @@ -454,6 +454,25 @@ AcpiAml acpi_call4(const char *method, AcpiAml arg1, AcpiAml arg2, > return var; > } > > +/* > + * ACPI 5.0: 19.5.62 IO (IO Resource Descriptor Macro) > + * 6.4.2 Small Resource Data Type > +*/ > +AcpiAml acpi_io(acpiIODecode dec, uint16_t min_base, uint16_t max_base, > + uint8_t aln, uint8_t len) > +{ > + AcpiAml var = aml_allocate_internal(0, NON_BLOCK); > + build_append_byte(var.buf, 0x47); /* IO port descriptor */ > + build_append_byte(var.buf, dec); > + build_append_byte(var.buf, min_base & 0xff); > + build_append_byte(var.buf, (min_base >> 8) & 0xff); > + build_append_byte(var.buf, max_base & 0xff); > + build_append_byte(var.buf, (max_base >> 8) & 0xff); > + build_append_byte(var.buf, aln); > + build_append_byte(var.buf, len); > + return var; > +} > + > /* ACPI 5.0: 20.2.5.3 Type 1 Opcodes Encoding: DefIfElse */ > AcpiAml acpi_if(AcpiAml predicate) > { > diff --git a/include/hw/acpi/acpi-build-utils.h b/include/hw/acpi/acpi-build-utils.h > index 594fae7..91575f1 100644 > --- a/include/hw/acpi/acpi-build-utils.h > +++ b/include/hw/acpi/acpi-build-utils.h > @@ -19,6 +19,11 @@ typedef struct AcpiAml { > AcpiBlockFlags block_flags; > } AcpiAml; > > +typedef enum { > + acpi_decode10 = 0, > + acpi_decode16 = 1, > +} acpiIODecode; A really small comment, you mean AcpiIODecode and not acpiIODecode, right? Thanks, Marcel > + > void aml_append(AcpiAml *parent_ctx, AcpiAml child); > > /* non block ASL object primitives */ > @@ -39,6 +44,8 @@ AcpiAml acpi_call3(const char *method, AcpiAml arg1, AcpiAml arg2, > AcpiAml arg3); > AcpiAml acpi_call4(const char *method, AcpiAml arg1, AcpiAml arg2, > AcpiAml arg3, AcpiAml arg4); > +AcpiAml acpi_io(acpiIODecode dec, uint16_t min_base, uint16_t max_base, > + uint8_t aln, uint8_t len); > > /* Block ASL object primitives */ > AcpiAml acpi_if(AcpiAml predicate); >