Re: [PATCH V2 15/15] mmc: core: Don't print reset warning if reset is not supported

From: Arend van Spriel <arend@broadcom.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Chris Ball <chris@printf.net>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Aaron Lu <aaron.lu@intel.com>, Philip Rakity <prakity@nvidia.com>,
	Girish K S <girish.shivananjappa@linaro.org>,
	Al Cooper <alcooperx@gmail.com>
Subject: Re: [PATCH V2 15/15] mmc: core: Don't print reset warning if reset is not supported
Date: Mon, 9 Feb 2015 10:33:48 +0100	[thread overview]
Message-ID: <54D87EFC.9060404@broadcom.com> (raw)
In-Reply-To: <1422522030-17793-16-git-send-email-adrian.hunter@intel.com>

On 01/29/15 10:00, Adrian Hunter wrote:
> Check the error code for EOPNOTSUPP and do not print
> reset warning in that case.
>
> Signed-off-by: Adrian Hunter<adrian.hunter@intel.com>
> ---
>   drivers/mmc/core/core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 392a150..d439bf0 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -2368,7 +2368,8 @@ int mmc_hw_reset(struct mmc_host *host)
>   	ret = host->bus_ops->reset(host);
>   	mmc_bus_put(host);
>
> -	pr_warn("%s: tried to reset card\n", mmc_hostname(host));
> +	if (ret != -EOPNOTSUPP)
> +		pr_warn("%s: tried to reset card\n", mmc_hostname(host));

Guess you don't want this message either if ret is zero.

Gr. Avs

>   	return ret;
>   }