From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKwjh-0001km-0E for qemu-devel@nongnu.org; Mon, 09 Feb 2015 17:23:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKwjd-0000Dj-0r for qemu-devel@nongnu.org; Mon, 09 Feb 2015 17:23:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKwjc-0000Df-Oe for qemu-devel@nongnu.org; Mon, 09 Feb 2015 17:23:16 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t19MNFlt018897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Feb 2015 17:23:16 -0500 Message-ID: <54D93352.1030506@redhat.com> Date: Mon, 09 Feb 2015 15:23:14 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423501897-30410-1-git-send-email-mreitz@redhat.com> <1423501897-30410-29-git-send-email-mreitz@redhat.com> In-Reply-To: <1423501897-30410-29-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UgHIPaXnbq9J4VXjSDDaLCoe84GD4iccf" Subject: Re: [Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , John Snow , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UgHIPaXnbq9J4VXjSDDaLCoe84GD4iccf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/09/2015 10:11 AM, Max Reitz wrote: > And a helper function for that which directly takes a pointer to the BD= S reads better with s/that/that,/ > to be inserted instead of its node-name (which will be used for > implementing 'change' using blockdev-insert-medium). >=20 > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > blockdev.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > qapi/block-core.json | 17 +++++++++++++++++ > qmp-commands.hx | 37 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 97 insertions(+) But a grammar nit in the commit message doesn't invalidate R-b :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UgHIPaXnbq9J4VXjSDDaLCoe84GD4iccf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU2TNSAAoJEKeha0olJ0NqbHkH/3uHQNhItdcIICrWVTFz0kWn uqla+4TdPiRfSQYWSfRlgxagTnLaVN0wWJO2X9TDPg6lnIf+SJlFkZ0pLntFVECT adWK908Z/7rIZqHJ6u4afNx5pch5Xom9Liix/Ua9tsie5g+PH5ApgHx1qvaGyay5 RDxsWhBu95+hPn6aotmd6dbx/Zr/5pUVeckUthxwVTx8665LQ/sb434/Q47wr7qi JVaJezsZW52wPYh3VB+1/Ksv3SQ/NKQmXzLs8mn3+mMk304sJB/aDGOlq8izEhTh vp2wp8z3QRd8ynnfSNtADI4oLYXzQl4wA1BtAoroQ89EXYgKnqH4lUPKKIU/cp0= =WYwE -----END PGP SIGNATURE----- --UgHIPaXnbq9J4VXjSDDaLCoe84GD4iccf--