All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linhaifeng <haifeng.lin@huawei.com>
To: Gonglei <arei.gonglei@huawei.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 2/2] vhost-user: add reply for set_mem_table
Date: Tue, 10 Feb 2015 14:54:17 +0800	[thread overview]
Message-ID: <54D9AB19.7030008@huawei.com> (raw)
In-Reply-To: <54D9A6BF.1050703@huawei.com>



On 2015/2/10 14:35, Gonglei wrote:
> On 2015/2/10 13:48, linhaifeng wrote:
>> From: Linhaifeng <haifeng.lin@huawei.com>
>>
>> If u64 is not 0 we should return -1 to tell qemu not going on.
>>
>> Remove some unnecessary '\n' in error_report.
> Hi, haifeng:
> 
> You'd better split a single patch to do this work,
> and using '--cover' argument for patch series when git format-patch .  :)
> 

good idea!

> Regards,
> -Gonglei
>>
>> Signed-off-by: Linhaifeng <haifeng.lin@huawei.com>
>> ---
>>  hw/virtio/vhost-user.c | 33 ++++++++++++++++++++++-----------
>>  1 file changed, 22 insertions(+), 11 deletions(-)
> 
> 
> 
> .
> 

-- 
Regards,
Haifeng

  reply	other threads:[~2015-02-10  6:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  5:48 [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap linhaifeng
2015-02-10  5:48 ` [Qemu-devel] [PATCH v1 2/2] vhost-user: add reply for set_mem_table linhaifeng
2015-02-10  6:35   ` Gonglei
2015-02-10  6:54     ` Linhaifeng [this message]
2015-02-10  8:46 ` [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap Michael S. Tsirkin
2015-02-10 10:27   ` Linhaifeng
2015-02-10 10:41     ` Michael S. Tsirkin
2015-02-10 11:59       ` Linhaifeng
2015-02-10 12:04         ` Michael S. Tsirkin
2015-02-11  1:38           ` Linhaifeng
2015-02-12 16:38             ` Michael S. Tsirkin
2015-02-11  6:30           ` Linhaifeng
2015-02-12  3:25           ` Linhaifeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D9AB19.7030008@huawei.com \
    --to=haifeng.lin@huawei.com \
    --cc=arei.gonglei@huawei.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.