From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v3 2/7] pci: Do not ignore device's PXM information Date: Tue, 10 Feb 2015 11:43:03 +0000 Message-ID: <54D9FCD7020000780005E933__762.092139530246$1423568686$gmane$org@mail.emea.novell.com> References: <1423512275-6531-1-git-send-email-boris.ostrovsky@oracle.com> <1423512275-6531-3-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423512275-6531-3-git-send-email-boris.ostrovsky@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, port-xen@netbsd.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, ufimtseva@gmail.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org >>> On 09.02.15 at 21:04, wrote: > If ACPI provides PXM data for IO devices then dom0 will pass it to > hypervisor during PHYSDEVOP_pci_device_add call. This information, > however, is currently ignored. > > We will store this information (in the form of nodeID) in pci_dev > structure so that we can provide it, for example, to the toolstack > when it adds support (in the following patches) for querying the > hypervisor about device topology > > We will also print it when user requests device information dump. > > Signed-off-by: Boris Ostrovsky I disagree with the title - you still effectively ignore the value. Displaying it upon debug key request doesn't really count as a use. The patch itself, otoh is fine, so with the title adjusted to state reality Acked-by: Jan Beulich Jan