From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laszlo Ersek Subject: Re: [PATCH v3 25/27] ArmVirtualizationPkg: add XenIoMmioLib Date: Tue, 10 Feb 2015 14:52:10 +0100 Message-ID: <54DA0D0A.7060603__42778.8633307957$1423576457$gmane$org@redhat.com> References: <1422991212-9257-1-git-send-email-ard.biesheuvel@linaro.org> <1422991212-9257-26-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422991212-9257-26-git-send-email-ard.biesheuvel@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ard Biesheuvel Cc: julien.grall@linaro.org, ian.campbell@citrix.com, olivier.martin@arm.com, stefano.stabellini@eu.citrix.com, edk2-devel@lists.sourceforge.net, leif.lindholm@linaro.org, xen-devel@lists.xen.org, roy.franz@linaro.org, ilias.biris@linaro.org, anthony.perard@citrix.com, christoffer.dall@linaro.org List-Id: xen-devel@lists.xenproject.org On 02/03/15 20:20, Ard Biesheuvel wrote: > This adds a XenIoMmioLib declaration and implementation that can > be invoked to install the XENIO_PROTOCOL and a corresponding > grant table address on a EFI handle. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > OvmfPkg/Include/Library/XenIoMmioLib.h | 64 ++++++++++ > OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 166 ++++++++++++++++++++++++++ > OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf | 39 ++++++ > OvmfPkg/OvmfPkg.dec | 4 + > 4 files changed, 273 insertions(+) > create mode 100644 OvmfPkg/Include/Library/XenIoMmioLib.h > create mode 100644 OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c > create mode 100644 OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf There are two occurrences of the typo "if if" in this patch. In case you send a v4, please fix that. Reviewed-by: Laszlo Ersek I'm done with the v3 review; you addressed all my v2 comments. Thanks! Laszlo