Re: [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	jbeulich@suse.com, keir@xen.org, ian.jackson@eu.citrix.com,
	ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
	wei.liu2@citrix.com
Cc: dario.faggioli@citrix.com, port-xen@netbsd.org,
	ufimtseva@gmail.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc
Date: Tue, 10 Feb 2015 09:48:42 -0500	[thread overview]
Message-ID: <54DA1A4A.2080608__46707.0424384021$1423579840$gmane$org@oracle.com> (raw)
In-Reply-To: <54D9EA4A.3070506@citrix.com>

On 02/10/2015 06:23 AM, Andrew Cooper wrote:
>
>
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index 0cb6743..d94571d 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -1226,7 +1226,7 @@ int xc_readconsolering(xc_interface *xch,
>   int xc_send_debug_keys(xc_interface *xch, char *keys);
>   
>   typedef xen_sysctl_physinfo_t xc_physinfo_t;
> -typedef xen_sysctl_cputopoinfo_t xc_cputopoinfo_t;
> +typedef xen_sysctl_cputopo_t xc_cputopo_t;
> The sysctl structure is still named xen_sysctl_cputopoinfo_t.  Where
> does xen_sysctl_cputopo_t come from?

It's in patch 3 (the one you skipped), sysctl.h:

+struct xen_sysctl_cputopo {
+    uint32_t core;
+    uint32_t socket;
+    uint8_t node;
+};
+typedef struct xen_sysctl_cputopo xen_sysctl_cputopo_t;
+DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cputopo_t);

-boris