From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 12/21] KVM: x86: MOV to CR3 can set bit 63 Date: Tue, 10 Feb 2015 17:34:52 +0100 Message-ID: <54DA332C.30503@siemens.com> References: <1414922101-17626-1-git-send-email-namit@cs.technion.ac.il> <1414922101-17626-13-git-send-email-namit@cs.technion.ac.il> <54DA2EBA.10803@siemens.com> <54DA2F68.8080901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, nadav.amit@gmail.com To: Paolo Bonzini , Nadav Amit Return-path: Received: from thoth.sbs.de ([192.35.17.2]:53539 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbbBJQfK (ORCPT ); Tue, 10 Feb 2015 11:35:10 -0500 In-Reply-To: <54DA2F68.8080901@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2015-02-10 17:18, Paolo Bonzini wrote: > On 10/02/2015 17:15, Jan Kiszka wrote: >>>> #define CR3_L_MODE_RESERVED_BITS 0xFFFFFF0000000000ULL >>>> +#define CR3_PCID_INVD (1UL << 63) >> 1ULL (for i386) >=20 > Already fixed: >=20 > commit cfaa790a3fb8a7efa98f4a6457e19dc3a0db35d3 > Author: Borislav Petkov > Date: Thu Jan 15 09:44:56 2015 +0100 >=20 > kvm: Fix CR3_PCID_INVD type on 32-bit > =20 > arch/x86/kvm/emulate.c: In function =E2=80=98check_cr_write=E2=80= =99: > arch/x86/kvm/emulate.c:3552:4: warning: left shift count >=3D wid= th of type > rsvd =3D CR3_L_MODE_RESERVED_BITS & ~CR3_PCID_INVD; > =20 > happens because sizeof(UL) on 32-bit is 4 bytes but we shift it 6= 3 bits > to the left. > =20 > Signed-off-by: Borislav Petkov > Signed-off-by: Paolo Bonzini Ah, sorry. Your kvm-kmod queue lacked a source link update! Is this queued for stable as well? It's not in 3.19 apparently. >=20 >> Paolo, there is no 32-bit test build anymore on your side, right? >=20 > Reinstating it has been on my todo list for a while. But as of now > I'm not doing 32-bit tests. OK. Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux