From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v2 02/20] mbuf: enhance the API documentation of offload flags Date: Tue, 10 Feb 2015 17:54:31 +0100 Message-ID: <54DA37C7.6080603@6wind.com> References: <1422623775-8050-1-git-send-email-olivier.matz@6wind.com> <1423041925-26956-1-git-send-email-olivier.matz@6wind.com> <1423041925-26956-3-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: "Zhang, Helin" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Helin, On 02/10/2015 06:38 AM, Zhang, Helin wrote: >> -/** Packet is IPv4 without requiring IP checksum offload. */ >> +/** >> + * Packet is IPv4. This flag must be set when using any offload feature >> + * (TSO, L3 or L4 checksum) to tell the NIC that the packet is an IPv4 >> + * packet. >> + */ >> #define PKT_TX_IPV4 (1ULL << 55) >> >> -/** Tell the NIC it's an IPv6 packet.*/ >> +/** >> + * Packet is IPv6. This flag must be set when using an offload feature >> + * (TSO or L4 checksum) to tell the NIC that the packet is an IPv6 >> + * packet. >> + */ >> #define PKT_TX_IPV6 (1ULL << 56) > Above two macro for IPV4/IPV6 will be used for inner L3 for tunneling case, right? > If yes, the annotations may need to mention that, to avoid confusing end users. That's right, I'll clarify this in a next version. Thanks Olivier