From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 04/20] i40e: remove the use of
 PKT_TX_UDP_TUNNEL_PKT flag
Date: Tue, 10 Feb 2015 18:08:35 +0100
Message-ID: <54DA3B13.2010202@6wind.com>
References: <1422623775-8050-1-git-send-email-olivier.matz@6wind.com>
 <1423041925-26956-1-git-send-email-olivier.matz@6wind.com>
 <1423041925-26956-5-git-send-email-olivier.matz@6wind.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A806631@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: "Zhang, Helin" <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A806631-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Helin,

On 02/10/2015 07:40 AM, Zhang, Helin wrote:
>> diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c
>> index 9acdeee..0786255 100644
>> --- a/lib/librte_pmd_i40e/i40e_rxtx.c
>> +++ b/lib/librte_pmd_i40e/i40e_rxtx.c
>> @@ -482,7 +482,7 @@ i40e_txd_enable_checksum(uint64_t ol_flags,
>>   	}
>>
>>   	/* UDP tunneling packet TX checksum offload */
>> -	if (unlikely(ol_flags & PKT_TX_UDP_TUNNEL_PKT)) {
>> +	if (unlikely(ol_flags & PKT_TX_OUTER_IP_CKSUM)) {
> Unlikely might not be suitable anymore.

Right, I'll remove it.

Thanks