From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754365AbbBKWdq (ORCPT ); Wed, 11 Feb 2015 17:33:46 -0500 Received: from mail-la0-f50.google.com ([209.85.215.50]:39675 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754014AbbBKWdn (ORCPT ); Wed, 11 Feb 2015 17:33:43 -0500 Message-ID: <54DBD8C3.4090904@cogentembedded.com> Date: Thu, 12 Feb 2015 01:33:39 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Pavel Machek , pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com Subject: Re: -n900 (not mainline): fix compilation with 3.20-rc0 References: <20150211222342.GE11313@amd> In-Reply-To: <20150211222342.GE11313@amd> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 02/12/2015 01:23 AM, Pavel Machek wrote: This looked like a patch in its final form, so I decided to comment on it... > commit 02aa41563bd0f14268d2142ab69694880d3425a1 > Author: Pavel > Date: Wed Feb 11 23:22:51 2015 +0100 No need for this header. > Fix compilation of wl1251 specific parts with 3.20-rc0. > Signed-off-by: Pavel Machek Please don't indent the change log. > diff --git a/drivers/net/wireless/ti/wl1251/netlink.c b/drivers/net/wireless/ti/wl1251/netlink.c > index e5f5a45..90a5486 100644 > --- a/drivers/net/wireless/ti/wl1251/netlink.c > +++ b/drivers/net/wireless/ti/wl1251/netlink.c [...] > @@ -406,14 +398,10 @@ static int wl1251_nl_phy_reg_read(struct sk_buff *skb, struct genl_info *info) > if (nla_put_u32(msg, WL1251_NL_ATTR_REG_VAL, *reg_value)) > goto nla_put_failure; > > - ret = genlmsg_end(msg, hdr); > - if (ret < 0) { > - wl1251_error("%s() failed", __func__); > - goto nla_put_failure; > - } > + genlmsg_end(msg, hdr); > > kfree(reg_value); > - > + Remove this stray tab please. > return genlmsg_reply(msg, info); > > nla_put_failure: WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Thu, 12 Feb 2015 01:33:39 +0300 Subject: -n900 (not mainline): fix compilation with 3.20-rc0 In-Reply-To: <20150211222342.GE11313@amd> References: <20150211222342.GE11313@amd> Message-ID: <54DBD8C3.4090904@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 02/12/2015 01:23 AM, Pavel Machek wrote: This looked like a patch in its final form, so I decided to comment on it... > commit 02aa41563bd0f14268d2142ab69694880d3425a1 > Author: Pavel > Date: Wed Feb 11 23:22:51 2015 +0100 No need for this header. > Fix compilation of wl1251 specific parts with 3.20-rc0. > Signed-off-by: Pavel Machek Please don't indent the change log. > diff --git a/drivers/net/wireless/ti/wl1251/netlink.c b/drivers/net/wireless/ti/wl1251/netlink.c > index e5f5a45..90a5486 100644 > --- a/drivers/net/wireless/ti/wl1251/netlink.c > +++ b/drivers/net/wireless/ti/wl1251/netlink.c [...] > @@ -406,14 +398,10 @@ static int wl1251_nl_phy_reg_read(struct sk_buff *skb, struct genl_info *info) > if (nla_put_u32(msg, WL1251_NL_ATTR_REG_VAL, *reg_value)) > goto nla_put_failure; > > - ret = genlmsg_end(msg, hdr); > - if (ret < 0) { > - wl1251_error("%s() failed", __func__); > - goto nla_put_failure; > - } > + genlmsg_end(msg, hdr); > > kfree(reg_value); > - > + Remove this stray tab please. > return genlmsg_reply(msg, info); > > nla_put_failure: WBR, Sergei