From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v5 23/24] xl: introduce xcalloc Date: Thu, 12 Feb 2015 20:17:42 +0000 Message-ID: <54DD0A66.3070703@citrix.com> References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com> <1423770294-9779-24-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423770294-9779-24-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , xen-devel@lists.xen.org Cc: dario.faggioli@citrix.com, JBeulich@suse.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, ufimtseva@gmail.com List-Id: xen-devel@lists.xenproject.org On 12/02/15 19:44, Wei Liu wrote: > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson > --- > tools/libxl/xl_cmdimpl.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 440db78..ec7fb2d 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -289,6 +289,18 @@ static void *xmalloc(size_t sz) { > return r; > } > > +static void *xcalloc(size_t n, size_t sz) __attribute__((unused)); > +static void *xcalloc(size_t n, size_t sz) { > + void *r; > + r = calloc(n, sz); These two lines can be joined, espcially in a small wrapper like this. > + if (!r) { > + fprintf(stderr,"xl: Unable to calloc %lu bytes.\n", > + (unsigned long)sz * (unsigned long)n); %zu is the correct format identifier for a size_t, and it will allow you to drop the casts. ~Andrew > + exit(-ERROR_FAIL); > + } > + return r; > +} > + > static void *xrealloc(void *ptr, size_t sz) { > void *r; > if (!sz) { free(ptr); return 0; }