From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v3 3/7] sysctl: Make topologyinfo and numainfo sysctls a little more efficient Date: Fri, 13 Feb 2015 09:21:04 -0500 Message-ID: <54DE0850.6010304__21860.9944022775$1423837435$gmane$org@oracle.com> References: <1423512275-6531-1-git-send-email-boris.ostrovsky@oracle.com> <1423512275-6531-4-git-send-email-boris.ostrovsky@oracle.com> <20150213122609.GU13644@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150213122609.GU13644@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: keir@xen.org, ian.campbell@citrix.com, port-xen@netbsd.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, ufimtseva@gmail.com List-Id: xen-devel@lists.xenproject.org On 02/13/2015 07:26 AM, Wei Liu wrote: > On Mon, Feb 09, 2015 at 03:04:31PM -0500, Boris Ostrovsky wrote: >> Currently both of these sysctls make a copy to userspace for each index of >> various query arrays. We should try to copy whole arrays instead. >> >> This requires some changes in sysctl's public data structure, thus bump >> interface version. >> >> Report topology for all present (not just online) cpus. >> >> Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the fact >> that these are used for CPU topology. Subsequent patch will add support for >> PCI topology sysctl. >> >> Clarify some somments in sysctl.h. >> >> Signed-off-by: Boris Ostrovsky >> --- >> tools/libxc/include/xenctrl.h | 4 +- >> tools/libxc/xc_misc.c | 10 ++-- >> tools/libxl/libxl.c | 71 +++++++------------ >> tools/misc/xenpm.c | 69 +++++++----------- >> tools/python/xen/lowlevel/xc/xc.c | 77 ++++++++------------ > Are these mostly mechanical changes? I'm assuming yes. Pretty much, yes. -boris > >> xen/common/sysctl.c | 141 ++++++++++++++++++++++--------------- >> xen/include/public/sysctl.h | 75 ++++++++++++-------- >> 7 files changed, 221 insertions(+), 226 deletions(-) >