From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v3 7/7] libxl: Add interface for querying
 hypervisor about PCI topology
Date: Fri, 13 Feb 2015 09:22:21 -0500
Message-ID: <54DE089D.3010900__42300.9658385583$1423837521$gmane$org@oracle.com>
References: <1423512275-6531-1-git-send-email-boris.ostrovsky@oracle.com>
	<1423512275-6531-8-git-send-email-boris.ostrovsky@oracle.com>
	<20150213124345.GV13644@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150213124345.GV13644@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: keir@xen.org, ian.campbell@citrix.com, port-xen@netbsd.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, ufimtseva@gmail.com
List-Id: xen-devel@lists.xenproject.org

On 02/13/2015 07:43 AM, Wei Liu wrote:
> On Mon, Feb 09, 2015 at 03:04:35PM -0500, Boris Ostrovsky wrote:
> [...]
>> +#ifdef  LIBXL_HAVE_PCITOPO
>> +libxl_pcitopology *libxl_get_pci_topology(libxl_ctx *ctx, int *num_devs)
>> +{
>> +    GC_INIT(ctx);
>> +    physdev_pci_device_t *devs;
>> +    uint8_t *nodes;
>> +    libxl_pcitopology *ret = NULL;
>> +    int i, rc;
>> +
>> +    *num_devs = libxl__pci_numdevs(gc);
>> +    if (*num_devs <= 0) {
>> +        LOG(ERROR, "Unable to determine number of PCI devices");
> Is 0 an error? What if the system actually have no PCI devices?

Right, zero should be a non-error value.


-boris


>
> The rest looks OK to me.
>
> Wei.