From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v5 05/24] libxc: allocate memory with vNUMA
 information for PV guest
Date: Fri, 13 Feb 2015 14:30:30 +0000
Message-ID: <54DE0A86.7060900@citrix.com>
References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com>
	<1423770294-9779-6-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423770294-9779-6-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
Cc: dario.faggioli@citrix.com, JBeulich@suse.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, ufimtseva@gmail.com
List-Id: xen-devel@lists.xenproject.org

On 12/02/15 19:44, Wei Liu wrote:
> diff --git a/tools/libxc/xc_private.h b/tools/libxc/xc_private.h
> index 45b8644..1809674 100644
> --- a/tools/libxc/xc_private.h
> +++ b/tools/libxc/xc_private.h
> @@ -35,6 +35,8 @@
>  
>  #include <xen/sys/privcmd.h>
>  
> +#define XC_VNUMA_NO_NODE (~0U)

Shouldn't this sentinel value come from the Xen public API?

~Andrew

> +
>  #if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) && !defined(__MINIOS__)
>  /* Compile in Valgrind client requests? */
>  #include <valgrind/memcheck.h>