From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754160AbbBNQgU (ORCPT <rfc822;w@1wt.eu>);
	Sat, 14 Feb 2015 11:36:20 -0500
Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:20793 "EHLO
	mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752743AbbBNQgS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 14 Feb 2015 11:36:18 -0500
X-IronPort-AV: E=Sophos;i="5.09,576,1418112000"; 
   d="scan'208";a="57008862"
Message-ID: <54DF797B.40407@broadcom.com>
Date: Sat, 14 Feb 2015 08:36:11 -0800
From: Scott Branden <sbranden@broadcom.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Joe Perches <joe@perches.com>
CC: <bcm-kernel-feedback-list@broadcom.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        "Ian Campbell" <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Grant Likely <grant.likely@linaro.org>, Ray Jui <rjui@broadcom.com>,
        Jonathan Richardson <jonathar@broadcom.com>,
        Dmitry Torokhov <dtor@google.com>, Anatol Pomazao <anatol@google.com>,
        <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver
References: <Scott Branden <sbranden@broadcom.com>	 <1423526830-29516-1-git-send-email-sbranden@broadcom.com>	 <1423526830-29516-2-git-send-email-sbranden@broadcom.com> <1423528033.2933.29.camel@perches.com>
In-Reply-To: <1423528033.2933.29.camel@perches.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Joe,

I really don't see the missing terminating newlines in the patch or 
source code.  The lines look the same as every other line???

Regards,
  Scott

On 15-02-09 04:27 PM, Joe Perches wrote:
> On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote:
>> This adds a driver for random number generator present on Broadcom
>> IPROC devices.
>
> trivia:
>
>> diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
> []
>> +static int iproc_rng200_probe(struct platform_device *pdev)
>> +{
> []
>> +	if (!res) {
>> +		dev_err(dev, "failed to get rng resources");
>
> Missing terminating newline:
>
> 		dev_err(dev, "failed to get rng resources\n");
>
>> +	rng_base = devm_ioremap_resource(dev, res);
>> +	if (!rng_base) {
>> +		dev_err(dev, "failed to remap rng regs");
>
> here too.
>
>


From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Branden <sbranden@broadcom.com>
Subject: Re: [PATCH 1/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver
Date: Sat, 14 Feb 2015 08:36:11 -0800
Message-ID: <54DF797B.40407@broadcom.com>
References: <Scott Branden <sbranden@broadcom.com>	 <1423526830-29516-1-git-send-email-sbranden@broadcom.com>	 <1423526830-29516-2-git-send-email-sbranden@broadcom.com> <1423528033.2933.29.camel@perches.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1423528033.2933.29.camel@perches.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Joe Perches <joe@perches.com>
Cc: bcm-kernel-feedback-list@broadcom.com, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Matt Mackall <mpm@selenic.com>, Herbert Xu <herbert@gondor.apana.org.au>, Grant Likely <grant.likely@linaro.org>, Ray Jui <rjui@broadcom.com>, Jonathan Richardson <jonathar@broadcom.com>, Dmitry Torokhov <dtor@google.com>, Anatol Pomazao <anatol@google.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
List-Id: devicetree@vger.kernel.org

Hi Joe,

I really don't see the missing terminating newlines in the patch or 
source code.  The lines look the same as every other line???

Regards,
  Scott

On 15-02-09 04:27 PM, Joe Perches wrote:
> On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote:
>> This adds a driver for random number generator present on Broadcom
>> IPROC devices.
>
> trivia:
>
>> diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
> []
>> +static int iproc_rng200_probe(struct platform_device *pdev)
>> +{
> []
>> +	if (!res) {
>> +		dev_err(dev, "failed to get rng resources");
>
> Missing terminating newline:
>
> 		dev_err(dev, "failed to get rng resources\n");
>
>> +	rng_base = devm_ioremap_resource(dev, res);
>> +	if (!rng_base) {
>> +		dev_err(dev, "failed to remap rng regs");
>
> here too.
>
>

From mboxrd@z Thu Jan  1 00:00:00 1970
From: sbranden@broadcom.com (Scott Branden)
Date: Sat, 14 Feb 2015 08:36:11 -0800
Subject: [PATCH 1/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver
In-Reply-To: <1423528033.2933.29.camel@perches.com>
References: <Scott Branden <sbranden@broadcom.com>	
 <1423526830-29516-1-git-send-email-sbranden@broadcom.com>	
 <1423526830-29516-2-git-send-email-sbranden@broadcom.com>
 <1423528033.2933.29.camel@perches.com>
Message-ID: <54DF797B.40407@broadcom.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Joe,

I really don't see the missing terminating newlines in the patch or 
source code.  The lines look the same as every other line???

Regards,
  Scott

On 15-02-09 04:27 PM, Joe Perches wrote:
> On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote:
>> This adds a driver for random number generator present on Broadcom
>> IPROC devices.
>
> trivia:
>
>> diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
> []
>> +static int iproc_rng200_probe(struct platform_device *pdev)
>> +{
> []
>> +	if (!res) {
>> +		dev_err(dev, "failed to get rng resources");
>
> Missing terminating newline:
>
> 		dev_err(dev, "failed to get rng resources\n");
>
>> +	rng_base = devm_ioremap_resource(dev, res);
>> +	if (!rng_base) {
>> +		dev_err(dev, "failed to remap rng regs");
>
> here too.
>
>