All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Reyer <jens.reyer@gmail.com>
To: linux-acpi <linux-acpi@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: [PATCH] ACPI / video: Add disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D
Date: Sun, 15 Feb 2015 00:20:50 +0100	[thread overview]
Message-ID: <54DFD852.4080000@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

Hi

The native intel backlight controls do not work correctly on SAMSUNG
900X3C/900X3D/900X3E/900X4C/900X4D laptops as I reported in
https://bugs.freedesktop.org/show_bug.cgi?id=87286 (and
https://bugs.debian.org/772440).

Aaron Lu told me there to speak up here/to Rafael.

Please find attached a patch to disable the native backlight on this
laptop model, like it was already done for some other older models.

I assume this would be the proper commit comments (or should it be
signed-off?):
Bug-Link: https://bugs.freedesktop.org/show_bug.cgi?id=87286.
Reported-and-tested-by: Jens Reyer <jens.reyer@gmail.com>

The patch applies to
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
branch linux-next, head at
389a8d43d64711b0e7282d227e05a6a71b43753d
Rafael J. Wysocki 2015-02-12 22:43:26

I verified the issues are still present in linux-next and get solved
with this patch.

Just tell me if there is anything else I can do to get this applied.

Thanks
Jens Reyer/jre <jre.winesim@gmail.com>

[-- Attachment #2: disable_native_backlight_Samsung_900X.patch --]
[-- Type: text/x-patch, Size: 679 bytes --]

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 88a4f99..debd309 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -540,6 +540,15 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "730U3E/740U3E"),
 		},
 	},
+	{
+	 /* https://bugs.freedesktop.org/show_bug.cgi?id=87286 */
+	 .callback = video_disable_native_backlight,
+	 .ident = "SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "900X3C/900X3D/900X3E/900X4C/900X4D"),
+		},
+	},
 
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1163574 */

             reply	other threads:[~2015-02-14 23:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-14 23:20 Jens Reyer [this message]
2015-02-16  5:25 ` [PATCH] ACPI / video: Add disable_native_backlight quirk for SAMSUNG 900X3C/900X3D/900X3E/900X4C/900X4D Aaron Lu
2015-02-17 18:07   ` [PATCH v2] ACPI / video: Disable native backlight on Samsung Series 9 laptops Jens Reyer
2015-02-18  6:17     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DFD852.4080000@gmail.com \
    --to=jens.reyer@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.