From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v2 00/11] qemu vhost-user support Date: Mon, 16 Feb 2015 17:19:17 +0900 Message-ID: <54E1A805.2090209@igel.co.jp> References: <1423717649-11818-1-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Huawei Xie Return-path: In-Reply-To: <1423717649-11818-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/02/12 14:07, Huawei Xie wrote: > vhost-user supports passing vring information to a seperate vhost enabled > user space process, normally a user space vSwitch, through unix domain socket. > > In previous DPDK version, we implement a user space character device driver > vhost-cuse in user space DPDK process. vring information is passed to the > cuse driver through ioctl call, including eventfds for interrupt injection and > host notification. A kernel module is developed to copy these fds from > qemu process into our process. We also need some trick to map guest memory. > (TODO: kickfd/callfd is reversed which causes confusion) > > known issue in vhost-user implementation in QEMU, reported by haifeng.lin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org > * QEMU doesn't send correct memory region information with multiple numa node configuration > http://lists.gnu.org/archive/html/qemu-devel/2014-12/msg01454.html > > Thanks Tetsuya for reporting the issue that "FD_ISSET would crash when receive -1 > as fd on Ubuntu 14.04". > > Huawei Xie (11): > enable VIRTIO_NET_F_CTRL_RX > create vhost_cuse directory and move vhost-net-cdev.c into vhost_cuse > rename vhost-net-cdev.h to vhost-net.h > move fd copying(from qemu process into vhost process) to eventfd_copy.c > copy host_memory_map from virtio-net.c to a new file virtio-net-cdev.c > make host_memory_map a more generic function. > implement cuse_set_memory_table in virtio-net-cdev.c > add select based event driven processing > vhost user support > support dev->ifname > support calling rte_vhost_driver_register after rte_vhost_driver_session_start > > lib/librte_vhost/Makefile | 8 +- > lib/librte_vhost/rte_virtio_net.h | 5 +- > lib/librte_vhost/vhost-net-cdev.c | 389 -------------------- > lib/librte_vhost/vhost-net-cdev.h | 113 ------ > lib/librte_vhost/vhost-net.h | 118 +++++++ > lib/librte_vhost/vhost_cuse/eventfd_copy.c | 88 +++++ > lib/librte_vhost/vhost_cuse/eventfd_copy.h | 39 ++ > lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 417 ++++++++++++++++++++++ > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 423 ++++++++++++++++++++++ > lib/librte_vhost/vhost_cuse/virtio-net-cdev.h | 48 +++ > lib/librte_vhost/vhost_rxtx.c | 2 +- > lib/librte_vhost/vhost_user/fd_man.c | 258 ++++++++++++++ > lib/librte_vhost/vhost_user/fd_man.h | 67 ++++ > lib/librte_vhost/vhost_user/vhost-net-user.c | 472 +++++++++++++++++++++++++ > lib/librte_vhost/vhost_user/vhost-net-user.h | 106 ++++++ > lib/librte_vhost/vhost_user/virtio-net-user.c | 314 ++++++++++++++++ > lib/librte_vhost/vhost_user/virtio-net-user.h | 49 +++ > lib/librte_vhost/virtio-net.c | 491 ++------------------------ > lib/librte_vhost/virtio-net.h | 43 +++ > 19 files changed, 2491 insertions(+), 959 deletions(-) > delete mode 100644 lib/librte_vhost/vhost-net-cdev.c > delete mode 100644 lib/librte_vhost/vhost-net-cdev.h > create mode 100644 lib/librte_vhost/vhost-net.h > create mode 100644 lib/librte_vhost/vhost_cuse/eventfd_copy.c > create mode 100644 lib/librte_vhost/vhost_cuse/eventfd_copy.h > create mode 100644 lib/librte_vhost/vhost_cuse/vhost-net-cdev.c > create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.c > create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.h > create mode 100644 lib/librte_vhost/vhost_user/fd_man.c > create mode 100644 lib/librte_vhost/vhost_user/fd_man.h > create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.c > create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.h > create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.c > create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.h > create mode 100644 lib/librte_vhost/virtio-net.h > Hi Xie, I have 2 questions about v2 patches. Could you please check my other emails? Also checkpatch.pl reports some warnings. I am not sure how strictly we should follow checkpatch.pl. Here is what I did. $ git show --format=email | checkpatch.pl --no-tree --no-signoff -q - Is there a consensus how to use checkpatch.pl in DPDK community? Thanks, Tetsuya