From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNRnt-0001rl-Vs for qemu-devel@nongnu.org; Mon, 16 Feb 2015 14:58:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNRnq-0005eM-IY for qemu-devel@nongnu.org; Mon, 16 Feb 2015 14:58:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNRnq-0005dv-Bb for qemu-devel@nongnu.org; Mon, 16 Feb 2015 14:57:58 -0500 Message-ID: <54E24BC3.1020806@redhat.com> Date: Mon, 16 Feb 2015 14:57:55 -0500 From: Max Reitz MIME-Version: 1.0 References: <1423865338-8576-1-git-send-email-jsnow@redhat.com> <1423865338-8576-5-git-send-email-jsnow@redhat.com> In-Reply-To: <1423865338-8576-5-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v13 04/17] block: Introduce bdrv_dirty_bitmap_granularity() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 2015-02-13 at 17:08, John Snow wrote: > This returns the granularity (in bytes) of dirty bitmap, > which matches the QMP interface and the existing query > interface. > > Small adjustments are made to ensure that granularity (in bytes) > is handled consistently as a uint32_t throughout the code. This part of the patch seems to have been replaced by patch 2. > Signed-off-by: John Snow > --- > block.c | 8 ++++++-- > include/block/block.h | 1 + > 2 files changed, 7 insertions(+), 2 deletions(-) > If you remove said paragraph (or if the respective maintainer does), or if you have good reason to keep it: Reviewed-by: Max Reitz