From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNT3f-00059f-0w for qemu-devel@nongnu.org; Mon, 16 Feb 2015 16:18:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNT3a-0006Me-3R for qemu-devel@nongnu.org; Mon, 16 Feb 2015 16:18:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNT3Z-0006MY-Qj for qemu-devel@nongnu.org; Mon, 16 Feb 2015 16:18:18 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1GLIG1W007044 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 16 Feb 2015 16:18:17 -0500 Message-ID: <54E25BDC.1070609@redhat.com> Date: Mon, 16 Feb 2015 14:06:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424097865-3973-1-git-send-email-armbru@redhat.com> <1424097865-3973-4-git-send-email-armbru@redhat.com> In-Reply-To: <1424097865-3973-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RoUfVEulqj2XgM9J2Qi18lcS5vMdA1XBm" Subject: Re: [Qemu-devel] [PATCH 03/13] QemuOpts: Convert qemu_opts_set() to Error, fix its use List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, kraxel@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RoUfVEulqj2XgM9J2Qi18lcS5vMdA1XBm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2015 07:44 AM, Markus Armbruster wrote: > Return the Error object instead of reporting it with > qerror_report_err(). >=20 > Change callers that assume the function can't fail to pass > &error_abort, so that should the assumption ever break, it'll break > noisily. >=20 > Turns out all callers outside its unit test assume that. We could > drop the Error ** argument, but that would make the interface less > regular, so don't. >=20 > Signed-off-by: Markus Armbruster > --- > include/qemu/option.h | 4 ++-- > net/net.c | 4 ++-- > tests/test-qemu-opts.c | 6 +++--- > util/qemu-option.c | 11 +++++------ > vl.c | 15 ++++++++++----- > 5 files changed, 22 insertions(+), 18 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RoUfVEulqj2XgM9J2Qi18lcS5vMdA1XBm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU4lvcAAoJEKeha0olJ0NqoLYIAJm62uCX60okk8X/4akVTNrg ZXPKCmbCU5aJWhjXGNW08WcobSvbliTLX0eKsmef0S3FTELw7VarMugPCsxSqRGU /cwyTF6Reo+ERe1eCA3dx7kEVRwgH4z5XfET7+6jK+dsW91f/o2O7Jhi++pPSrmv bpDgyfrZMwxyiFFQ5MTqWej/XRDku+5XiJ3ernambq9gNHplvpcG9AiRMQlHESiv o30cMeXJXRL9X8jm7dFg0dBb/hsNXUBDzdxpErtwLttXsRlxZCbdUOsGkWsNj64i eh3MLIBamon1g+UZD9XT3/ZJSQ2qcunMHceE5hjT5Ixww3tm9SmsAYXlmgLtli4= =iJtD -----END PGP SIGNATURE----- --RoUfVEulqj2XgM9J2Qi18lcS5vMdA1XBm--