From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNU7N-0006qq-RT for qemu-devel@nongnu.org; Mon, 16 Feb 2015 17:26:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNU7M-0007s4-Ta for qemu-devel@nongnu.org; Mon, 16 Feb 2015 17:26:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNU7M-0007rw-LR for qemu-devel@nongnu.org; Mon, 16 Feb 2015 17:26:16 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1GMQFKp027629 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 16 Feb 2015 17:26:15 -0500 Message-ID: <54E26E86.6020506@redhat.com> Date: Mon, 16 Feb 2015 15:26:14 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424097865-3973-1-git-send-email-armbru@redhat.com> <1424097865-3973-6-git-send-email-armbru@redhat.com> In-Reply-To: <1424097865-3973-6-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W3hB1QflIa9c34K1od4XaibOTcx5O2ivc" Subject: Re: [Qemu-devel] [PATCH 05/13] block: Suppress unhelpful extra errors in bdrv_img_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, kraxel@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --W3hB1QflIa9c34K1od4XaibOTcx5O2ivc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2015 07:44 AM, Markus Armbruster wrote: > bdrv_img_create() uses qemu_opt_set(), which reports errors with > qerror_report_err(). Its error messages aren't helpful here, the > caller reports one that actually makes sense. I don't know how to > trigger the error conditions, though. >=20 > Switch to qemu_opt_set_err() to get rid of the unwanted messages. >=20 > Signed-off-by: Markus Armbruster > --- > block.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --W3hB1QflIa9c34K1od4XaibOTcx5O2ivc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU4m6GAAoJEKeha0olJ0NqFp8IAJS9FF11XZ7oPFnZKoNOCTYW EmRq02M2eeOkujD/f6Yj09XZiGhnvpdhLEN0dZlG+zLbDu9o8aD72E4RQRTX4i+5 7OPhNTaEDCmbNvn6IvTgbKuK7i8xasyDYF5inX33DjEcWQYIHdkgrYXzdTvNk5ve uI9k7Yig10rGOsosbEeRkElirQXbc9IbSYokahXiq0rCS0Dp9H1YmjWHHtBN9H7j b83dQiojtmYEiZ17xRMTDA6VsaPn01ZdlgopXrE8ffV3d49EeHKR2THnErCjfWx7 RUxHf9wrmEsR+GnHfmu8IqpN7xk3UHvO0bMOiC70cSAlKMKMmavvfC32YYCfiHQ= =iD0f -----END PGP SIGNATURE----- --W3hB1QflIa9c34K1od4XaibOTcx5O2ivc--