Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

From: Eric Blake <eblake@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Simon Zolin <szolin@parallels.com>,
	"Denis V. Lunev" <den@openvz.org>
Subject: Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring
Date: Tue, 17 Feb 2015 08:27:43 -0700	[thread overview]
Message-ID: <54E35DEF.3020309@redhat.com> (raw)
In-Reply-To: <1424142892-7275-4-git-send-email-mdroth@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

On 02/16/2015 08:14 PM, Michael Roth wrote:
> From: Simon Zolin <szolin@parallels.com>
> 
> Moved the code that sets non-blocking flag on fd into a separate function.
> 
> Signed-off-by: Simon Zolin <szolin@parallels.com>
> Reviewed-by: Roman Kagan <rkagan@parallels.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Michael Roth <mdroth@linux.vnet.ibm.com>
> CC: Eric Blake <eblake@redhat.com>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  qga/commands-posix.c | 31 +++++++++++++++++++++++--------
>  1 file changed, 23 insertions(+), 8 deletions(-)
> 
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 57409d0..ed527a3 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -376,13 +376,33 @@ safe_open_or_create(const char *path, const char *mode, Error **errp)
>      return NULL;
>  }
>  
> +static int guest_file_toggle_flags(int fd, int flags, bool set, Error **err)
> +{

Why are you reinventing qemu_set_nonblock()?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]