From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH V5 12/12] xen/vm_event: Add RESUME option to
 vm_event_op domctl
Date: Tue, 17 Feb 2015 14:31:55 +0000
Message-ID: <54E35EEB0200007800060A44@mail.emea.novell.com>
References: <1423845203-18941-1-git-send-email-tamas.lengyel@zentific.com>
	<1423845203-18941-13-git-send-email-tamas.lengyel@zentific.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423845203-18941-13-git-send-email-tamas.lengyel@zentific.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, steve@zentific.com, stefano.stabellini@eu.citrix.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, andres@lagarcavilla.org, jun.nakajima@intel.com, rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov, yanghy@cn.fujitsu.com
List-Id: xen-devel@lists.xenproject.org

>>> On 13.02.15 at 17:33, <tamas.lengyel@zentific.com> wrote:
> @@ -611,13 +611,22 @@ int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *vec,
>          }
>          break;
>  
> -        case XEN_VM_EVENT_PAGING_DISABLE:
> +        case XEN_VM_EVENT_DISABLE:
>          {
>              if ( ved->ring_page )
>                  rc = vm_event_disable(d, ved);
>          }
>          break;
>  
> +        case XEN_VM_EVENT_RESUME:
> +        {
> +            if ( ved->ring_page )
> +                vm_event_resume(d, ved);
> +            else
> +                rc = -ENODEV;
> +        }
> +        break;

Stray braces again.

I also find it confusing that the same set of changes repeats three
times here - is that an indication of a problem with an earlier patch?

Jan