From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNlHB-0000Sb-UP for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:45:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNlH8-0008Mw-Ot for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:45:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNlH8-0008MS-FV for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:45:30 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1HGjTSN007097 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 17 Feb 2015 11:45:29 -0500 Message-ID: <54E37028.3070001@redhat.com> Date: Tue, 17 Feb 2015 09:45:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424097865-3973-1-git-send-email-armbru@redhat.com> <1424097865-3973-12-git-send-email-armbru@redhat.com> In-Reply-To: <1424097865-3973-12-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nkjPtLXSMOrNvvRWbBtUgcwUP2MinOjd4" Subject: Re: [Qemu-devel] [PATCH 11/13] qemu-sockets: Simplify setting numeric and boolean options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, kraxel@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nkjPtLXSMOrNvvRWbBtUgcwUP2MinOjd4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2015 07:44 AM, Markus Armbruster wrote: > Don't convert numbers or bools to strings for use with qemu_opt_set(), > simply use qemu_opt_set_number() or qemu_opt_set_bool() instead. >=20 > Signed-off-by: Markus Armbruster > --- > util/qemu-sockets.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nkjPtLXSMOrNvvRWbBtUgcwUP2MinOjd4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU43AoAAoJEKeha0olJ0NqOtcH/jetfxODQjFt6l2vxHgF1bnF W6DRFuJpNn3azXYCOI5IlJNP6pdvzeWilajCxNEczXUmXXP4fUeu0GjM3pftOe13 BJHpyekIzCmluOdodYhwAIPo8GR5jpgE1aqIxLBUu9Dix7dlHHp7/mNOf2IPINUW gVr3zVk0IQ1YkArFrJ7KwgokkXhYTR4bcxGYOowu1+hPw51ln9BFQ0JfPSjjrtEK HYc74aIbN3Un66FR25DMA3rZNapkyrqupenO+ggwXwksHGNinFSM5tB1WN+nmJso aPC2il6xrvtqO7Sf02HDmOokbadbj2pgMrk3yxULX0qYiWm9DyEIQuogO4kbw7E= =id5R -----END PGP SIGNATURE----- --nkjPtLXSMOrNvvRWbBtUgcwUP2MinOjd4--