All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Praznik <frank.praznik@gmail.com>
To: Antonio Ospite <ao2@ao2.it>, linux-input@vger.kernel.org
Cc: Jiri Kosina <jkosina@suse.cz>, Lauri Kasanen <cand@gmx.com>,
	Frank Praznik <frank.praznik@oh.rr.com>
Subject: Re: [PATCH 0/5] HID: sony: misc fixes and cleanups
Date: Tue, 17 Feb 2015 13:03:31 -0500	[thread overview]
Message-ID: <54E38273.9040200@gmail.com> (raw)
In-Reply-To: <1424106744-12872-1-git-send-email-ao2@ao2.it>

On 2/16/2015 12:12, Antonio Ospite wrote:
> Hi,
>
> here are a few cleanups for hid-sony.
>
> Changes are meant to follow the patch titled:
> [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers
>
> Frank, hi, I'd like to have your explicit ack at least for patch 1 and
> 2.
>
> Thanks,
>     Antonio
>
>
> Antonio Ospite (5):
>    HID: sony: Fix a WARNING shown when rmmod-ing the driver
>    HID: sony: Use the minimum accepted size for feature report 0xf2
>    HID: sony: Don't use magic numbers in sixaxis_set_operational_usb()
>    HID: sony: Use __u8 * for the buffer in sixaxis_set_operational_usb()
>    HID: sony: Coding style cleanups in sixaxis_set_operational_usb()
>
>   drivers/hid/hid-sony.c | 21 +++++++++++----------
>   1 file changed, 11 insertions(+), 10 deletions(-)
>

The series looks good to me.  Thanks for tackling the last bit of magic 
constant cleanup.
For the entire series:

Acked-by: Frank Praznik <frank.praznik@oh.rr.com>

  parent reply	other threads:[~2015-02-17 18:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 13:06 [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers Lauri Kasanen
2015-02-16 16:59 ` Antonio Ospite
2015-02-17 12:18   ` Jiri Kosina
2015-02-16 17:12 ` [PATCH 0/5] HID: sony: misc fixes and cleanups Antonio Ospite
2015-02-16 17:12   ` [PATCH 2/5] HID: sony: Use the minimum accepted size for feature report 0xf2 Antonio Ospite
2015-02-16 17:12   ` [PATCH 3/5] HID: sony: Don't use magic numbers in sixaxis_set_operational_usb() Antonio Ospite
2015-02-16 17:12   ` [PATCH 4/5] HID: sony: Use __u8 * for the buffer " Antonio Ospite
2015-02-16 17:12   ` [PATCH 5/5] HID: sony: Coding style cleanups " Antonio Ospite
2015-02-16 21:48   ` [PATCH 0/5] HID: sony: misc fixes and cleanups Frank Praznik
2015-02-16 22:29     ` Antonio Ospite
2015-02-16 21:58   ` [PATCH 1/5] HID: sony: Fix a WARNING shown when rmmod-ing the driver Antonio Ospite
2015-02-17 18:03   ` Frank Praznik [this message]
2015-02-18 20:41   ` [PATCH 0/5] HID: sony: misc fixes and cleanups Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E38273.9040200@gmail.com \
    --to=frank.praznik@gmail.com \
    --cc=ao2@ao2.it \
    --cc=cand@gmx.com \
    --cc=frank.praznik@oh.rr.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.