From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH V5 09/12] xen/vm_event: Decouple vm_event
 and mem_access.
Date: Tue, 17 Feb 2015 18:34:56 +0000
Message-ID: <54E389D0.2070209@citrix.com>
References: <1423845203-18941-1-git-send-email-tamas.lengyel@zentific.com>	<1423845203-18941-10-git-send-email-tamas.lengyel@zentific.com>	<54E35B6D0200007800060A07@mail.emea.novell.com>
	<CAErYnsgR1KjmS6qAasqes-fvS4S4KL3Cedmsw6pTYHfOM5vFtg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAErYnsgR1KjmS6qAasqes-fvS4S4KL3Cedmsw6pTYHfOM5vFtg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tamas.lengyel@zentific.com>, Jan Beulich <JBeulich@suse.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Steven Maresca <steve@zentific.com>, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "Dong,
	Eddie" <eddie.dong@intel.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jun Nakajima <jun.nakajima@intel.com>, "rshriram@cs.ubc.ca" <rshriram@cs.ubc.ca>, Keir Fraser <keir@xen.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, "yanghy@cn.fujitsu.com" <yanghy@cn.fujitsu.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 17/02/15 18:30, Tamas K Lengyel wrote:
>> All these whitespace changes here and further down don't really
>> belong in this patch - please again get this right when adding the
>> code.
> Same issue I mentioned in the other patch: git -M can't track the
> files if indentation is fixed as part of the renaming process. As I
> end up touching all the files that have with minor style issues like
> this in the series as a result of the renaming, I fix them as I go
> along. If that stretches the rules, I will need to add a whole new
> separate patch just for indentation fixing.

Separating the two is best for review.

One patch which git diff -M says is identical for moving the file, and
one patch which git diff -w says is identical for whitespace fixes.

It makes it trivial to confirm that there is no functional change involved.

~Andrew