From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 2/2] Remove RTE_MBUF_REFCNT references Date: Wed, 18 Feb 2015 11:47:58 +0100 Message-ID: <54E46DDE.3090805@6wind.com> References: <1424102913-18944-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1424102913-18944-3-git-send-email-sergio.gonzalez.monroy@intel.com> <54E45888.7070603@6wind.com> <20150218093548.GA14884@bricha3-MOBL3> <2601191342CEEE43887BDE71AB977258213EF5E4@irsmsx105.ger.corp.intel.com> <20150218100003.GA14728@bricha3-MOBL3> <54E46612.7050809@6wind.com> <20150218102253.GA6804@bricha3-MOBL3> <54E46A8C.9010105@6wind.com> <20150218103703.GB6804@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Bruce Richardson Return-path: In-Reply-To: <20150218103703.GB6804@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, On 02/18/2015 11:37 AM, Bruce Richardson wrote: >>> How was this managed before, since refcnt field seems to be necessary in order >>> to effectively manage indirect mbufs? Is this just the case that this is something >>> that never worked and that needs to be solved, or is it something that was >>> working that this patch will now break? >> >> This is something that never worked before: refcounts are not compatible >> with reserving private data in mbufs. This patch does not change the >> issue, it is still there. >> >> Before the patch, an application that wanted to reserve a private >> data could disable refcounts at compile-time. >> After the patch, the solution is just to avoid using refcounts. >> >> Regards, >> Olivier >> > Thanks for clarifying. > So, you ok with this patch as a step in the right direction? Yep, Acked-by: Olivier Matz