Re: [PATCH v2 1/3] xen/arm: Add ThunderX platform support

[Julien Grall <julien.grall@linaro.org>]

Hello Vijay,

On 18/02/2015 12:19, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>
> Add basic support for Cavium ThunderX platform
>
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> ---
>   xen/arch/arm/platforms/Makefile   |    1 +
>   xen/arch/arm/platforms/thunderx.c |   66 +++++++++++++++++++++++++++++++++++++
>   xen/arch/arm/setup.c              |    1 +
>   3 files changed, 68 insertions(+)
>
> diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
> index e173fec..d9f98f9 100644
> --- a/xen/arch/arm/platforms/Makefile
> +++ b/xen/arch/arm/platforms/Makefile
> @@ -7,3 +7,4 @@ obj-$(CONFIG_ARM_32) += sunxi.o
>   obj-$(CONFIG_ARM_32) += rcar2.o
>   obj-$(CONFIG_ARM_64) += seattle.o
>   obj-$(CONFIG_ARM_64) += xgene-storm.o
> +obj-$(CONFIG_ARM_64) += thunderx.o
> diff --git a/xen/arch/arm/platforms/thunderx.c b/xen/arch/arm/platforms/thunderx.c
> new file mode 100644
> index 0000000..96560e1
> --- /dev/null
> +++ b/xen/arch/arm/platforms/thunderx.c
> @@ -0,0 +1,66 @@
> +/*
> + * xen/arch/arm/platforms/thunderx.c
> + *
> + * Cavium Thunder specific settings
> + *
> + * Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> + * Copyright (c) 2015 Cavium Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <asm/platform.h>
> +
> +static int thunderx_specific_mapping(struct domain *d)
> +{
> +    uint64_t addr, size;
> +    int res;
> +
> +    /* Mappings GSER region required for dom0 */

Mapping

> +    addr = 0x87e090000000;
> +    size = 0xd000000;
> +
> +    res = map_mmio_regions(d,
> +                           paddr_to_pfn(addr & PAGE_MASK),
> +                           DIV_ROUND_UP(size, PAGE_SIZE),
> +                           paddr_to_pfn(addr & PAGE_MASK));

OOI, why this region is not described in the DT? Is it a PCI device?

> +    if ( res )
> +    {
> +         printk(XENLOG_ERR "Unable to map to dom%d region"

It would be more clear to specify the name of the region i.e "GSER region"

Regards,

-- 
Julien Grall