From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH V6 04/13] xen: Rename mem_event to vm_event Date: Wed, 18 Feb 2015 13:35:22 +0000 Message-ID: <54E4A32A0200007800061161@mail.emea.novell.com> References: <1424218303-11331-1-git-send-email-tamas.lengyel@zentific.com> <1424218303-11331-5-git-send-email-tamas.lengyel@zentific.com> <54E46D6A0200007800060F85@mail.emea.novell.com> <1424262111.5799.17.camel@terminator> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1424262111.5799.17.camel@terminator> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , Tamas K Lengyel Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, steve@zentific.com, stefano.stabellini@eu.citrix.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, andres@lagarcavilla.org, jun.nakajima@intel.com, rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov, yanghy@cn.fujitsu.com List-Id: xen-devel@lists.xenproject.org >>> On 18.02.15 at 13:21, wrote: > On Wed Feb 18 2015 10:46:02 AM CET, Jan Beulich wrote: > >> > > > On 18.02.15 at 01:11, wrote: >> > diff --git a/xen/common/mem_event.c b/xen/common/vm_event.c >> > similarity index 59% >> > rename from xen/common/mem_event.c >> > rename to xen/common/vm_event.c >> >> Looking at this already quite huge delta I can't really see why >> adjusting white space at once would make it much worse. In any >> case better than leaving white space damage behind. > > I did that in the first version of the patch and the feedback I got was that > it is unreviewable that way. Not really - in the first version of the patch the old file gets removed as a whole, and the new file added. Same in v2 afaics, where indeed you got such a comment. Jan