From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH 01/29] libxl: Further fix exit paths from
	libxl_device_events_handler
Date: Wed, 18 Feb 2015 17:23:55 +0100
Message-ID: <54E4BC9B.6070408@citrix.com>
References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com>
	<1423599016-32639-2-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423599016-32639-2-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: Euan Harris <euan.harris@citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 10/02/15 a les 21.09, Ian Jackson ha escrit:
> On the success path, do not call GC_FREE explicitly.  Instead, call
> AO_INPROGRESS.
> =

> GC_FREE will free the gc underlying the long-term ao, which is then
> subsequently referenced in backend_watch_callback's call to
> libxl__nested_ao_create.  It is a miracle that this ever works at all.
> =

> Also, add an `if (rc) goto out;' after the xswatch registration.
> =

> After this, libxl_device_events_handler has the conventional and
> correct ao initiation pattern.
> =

> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Roger Pau Monn=E9 <roger.pau@citrix.com>