From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOEim-0004It-Pe for qemu-devel@nongnu.org; Wed, 18 Feb 2015 19:12:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOEii-0004QL-24 for qemu-devel@nongnu.org; Wed, 18 Feb 2015 19:12:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOEih-0004QH-Qm for qemu-devel@nongnu.org; Wed, 18 Feb 2015 19:11:55 -0500 Message-ID: <54E52A47.8040408@redhat.com> Date: Wed, 18 Feb 2015 19:11:51 -0500 From: John Snow MIME-Version: 1.0 References: <1424268014-13293-1-git-send-email-vsementsov@parallels.com> In-Reply-To: <1424268014-13293-1-git-send-email-vsementsov@parallels.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v3 00/14] Dirty bitmaps migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, quintela@redhat.com, dgilbert@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, den@openvz.org On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: > > rfc: there are two tests. They are the same but using different > interfaces: md5 checksum of the bitmap last layer in query-block or > separate query-block-dirty-bitmap with dirty bitmap regions. > The second form is more appropriate for debugging, the first is more > appropriate for simple regression control. Which should go to > upstream? Long term: The checksum for regression control. I think the region output by query-block-dirty-bitmap may be somewhat excessive during production use (a large bitmap may have many, many dirty bits) so its usage may be limited there. It's definitely very useful as a debug command; but the checksum is likely more useful for the regression tests as you say. We'll likely need to debug the bitmaps and the migration thereof for quite a bit of time in the near future, though, so it'd be a shame to discard the nice debugging interface. I wonder if we can conditionally compile in QMP commands exposed only in debug builds? I don't think we have any like that yet, but I could see a use for them. Thanks, --js