From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOVFv-000490-V8 for qemu-devel@nongnu.org; Thu, 19 Feb 2015 12:51:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOVFq-00050J-S6 for qemu-devel@nongnu.org; Thu, 19 Feb 2015 12:51:19 -0500 Received: from mx2.parallels.com ([199.115.105.18]:51735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOVFq-000507-Lg for qemu-devel@nongnu.org; Thu, 19 Feb 2015 12:51:14 -0500 Message-ID: <54E62282.4050004@openvz.org> Date: Thu, 19 Feb 2015 20:50:58 +0300 From: "Denis V. Lunev" MIME-Version: 1.0 References: <1424142892-7275-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424142892-7275-4-git-send-email-mdroth@linux.vnet.ibm.com> <54E35DEF.3020309@redhat.com> <54E36719.8040900@openvz.org> <20150217175635.13315.80188@loki> <54E38178.3000207@redhat.com> In-Reply-To: <54E38178.3000207@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Michael Roth , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Simon Zolin On 17/02/15 20:59, Eric Blake wrote: > On 02/17/2015 10:56 AM, Michael Roth wrote: >> In any case, since I was actually the one who re-invented it, >> and this code just moves it to another function, I think we >> can address it as a seperate patch and leave the PULL >> intact (unless there are other objections). > Agree that a separate cleanup patch would be okay. > OK. There is a portable way to detect whether the descriptor is a pipe or socket on Windows. Thus generic helper is possible. We'll provide you with one. ETA is something around next week.