From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753671AbbBTDHb (ORCPT ); Thu, 19 Feb 2015 22:07:31 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:36490 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753196AbbBTDH2 (ORCPT ); Thu, 19 Feb 2015 22:07:28 -0500 Message-ID: <54E6A4E9.4030401@linaro.org> Date: Fri, 20 Feb 2015 11:07:21 +0800 From: zhangfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: balbi@ti.com CC: Kishon Vijay Abraham I , mark.rutland@arm.com, Peter Chen , Sergei Shtylyov , "dan . zhao" , Wangbinghui , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v4 4/4] phy: add phy-hi6220-usb References: <1423726646-30336-1-git-send-email-zhangfei.gao@linaro.org> <1423726646-30336-5-git-send-email-zhangfei.gao@linaro.org> <54E4249C.9050404@ti.com> <54E426B5.4070206@linaro.org> <20150218143546.GD3651@saruman.tx.rr.com> In-Reply-To: <20150218143546.GD3651@saruman.tx.rr.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Balbi On 02/18/2015 10:35 PM, Felipe Balbi wrote: > On Wed, Feb 18, 2015 at 01:44:21PM +0800, zhangfei wrote: >> Hi, Kishon >> >> On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote: >>>> Add usb phy controller for hi6220 platform >>>> >>>> Signed-off-by: Zhangfei Gao >>>> --- >>>> drivers/phy/Kconfig | 9 ++ >>>> drivers/phy/Makefile | 1 + >>>> drivers/phy/phy-hi6220-usb.c | 306 >>>> +++++++++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 316 insertions(+) >>>> create mode 100644 drivers/phy/phy-hi6220-usb.c >>> >>> why is this driver in drivers/phy when it doesn't use the generic PHY >>> framework at all? >>> >> >> Balbi recommended "new drivers only on drivers/phy/", including usb >> phy. > > but it should use the API too. It's not only about a directory, you need > to use the new API. > >> So Move drivers/usb/phy/phy-hi6220-usb.c to >> drivers/phy/phy-hi6220-usb.c, required by Balbi. > > you're reading what I stated the way you like. Sorry for my bad understanding. Still not clear about the otg_set_peripheral, which is required in phy-hi6220-usb.c 1. drivers/usb/dwc2/gadget.c use otg_set_peripheral(hsotg->uphy->otg, &hsotg->gadget); 2. include/linux/phy/phy.h struct phy do not have member otg, while struct usb_phy has. Could you give more hints? Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangfei.gao@linaro.org (zhangfei) Date: Fri, 20 Feb 2015 11:07:21 +0800 Subject: [PATCH v4 4/4] phy: add phy-hi6220-usb In-Reply-To: <20150218143546.GD3651@saruman.tx.rr.com> References: <1423726646-30336-1-git-send-email-zhangfei.gao@linaro.org> <1423726646-30336-5-git-send-email-zhangfei.gao@linaro.org> <54E4249C.9050404@ti.com> <54E426B5.4070206@linaro.org> <20150218143546.GD3651@saruman.tx.rr.com> Message-ID: <54E6A4E9.4030401@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Balbi On 02/18/2015 10:35 PM, Felipe Balbi wrote: > On Wed, Feb 18, 2015 at 01:44:21PM +0800, zhangfei wrote: >> Hi, Kishon >> >> On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote: >>>> Add usb phy controller for hi6220 platform >>>> >>>> Signed-off-by: Zhangfei Gao >>>> --- >>>> drivers/phy/Kconfig | 9 ++ >>>> drivers/phy/Makefile | 1 + >>>> drivers/phy/phy-hi6220-usb.c | 306 >>>> +++++++++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 316 insertions(+) >>>> create mode 100644 drivers/phy/phy-hi6220-usb.c >>> >>> why is this driver in drivers/phy when it doesn't use the generic PHY >>> framework at all? >>> >> >> Balbi recommended "new drivers only on drivers/phy/", including usb >> phy. > > but it should use the API too. It's not only about a directory, you need > to use the new API. > >> So Move drivers/usb/phy/phy-hi6220-usb.c to >> drivers/phy/phy-hi6220-usb.c, required by Balbi. > > you're reading what I stated the way you like. Sorry for my bad understanding. Still not clear about the otg_set_peripheral, which is required in phy-hi6220-usb.c 1. drivers/usb/dwc2/gadget.c use otg_set_peripheral(hsotg->uphy->otg, &hsotg->gadget); 2. include/linux/phy/phy.h struct phy do not have member otg, while struct usb_phy has. Could you give more hints? Thanks