From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manish Jaggi <mjaggi@caviumnetworks.com>
Subject: Re: RFC: [PATCH 1/3] Enhance platform support for PCI
Date: Fri, 20 Feb 2015 18:04:57 +0530
Message-ID: <54E729F1.6000804@caviumnetworks.com>
References: <54E71BDE.5020106@caviumnetworks.com> <54E7229C.7000301@linaro.org>
	<54E72452.3090801@caviumnetworks.com> <54E72688.9010005@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54E72688.9010005@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>, xen-devel@lists.xen.org
Cc: Prasun.kapoor@cavium.com, "Kumar, Vijaya" <Vijaya.Kumar@caviumnetworks.com>, "Stefano Stabellini
	(Stefano.Stabellini@citrix.com)" <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org


On 20/02/15 5:50 pm, Julien Grall wrote:
> On 20/02/15 12:10, Manish Jaggi wrote:
>> On 20/02/15 5:33 pm, Julien Grall wrote:
>>> Hello Manish,
>>>
>>> On 20/02/15 11:34, Manish Jaggi wrote:
>>>> The platform APIs are enhanced to provide support for parsing pci device
>>>> tree nodes and storing the config-space address which is later used for
>>>> pci_read/pci_write config calls.
>>> Can you explain why you choose to add per-platform callbacks rather than
>>> a generic solution?
>> The platform code is similar to what linux has in
>> drivers/pci/host/pci-<platform>.c. I have used the same concept.
> Please explain it in the commit message, it helps us to understand why
> you did it.
>
> Anyway, based on what you said, your approach looks wrong.
ok :)
> Firstly, the platform code is DT-centric and we don't expect to have a
> such things for ACPI.
>
> Secondly, the PCI host code be shared between multiple platform.
>
> Overall, I would prefer to have a separate file and structure for
> handling PCI host. Also, I think we could re-use the Linux code for this
> purpose.
I will move the code to drivers/pci/host
> Regards,
>