From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 11/24] xen/arm: Let the toolstack
 configure the number of SPIs
Date: Fri, 20 Feb 2015 17:29:28 +0000
Message-ID: <54E76EF8.30208@linaro.org>
References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org>	
	<1421159133-31526-12-git-send-email-julien.grall@linaro.org>	
	<alpine.DEB.2.02.1501281821230.9702@kaball.uk.xensource.com>
	<1424448515.30924.334.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YOrOn-00054u-My
	for xen-devel@lists.xenproject.org; Fri, 20 Feb 2015 17:29:57 +0000
Received: by mail-wi0-f182.google.com with SMTP id l15so4452733wiw.3
	for <xen-devel@lists.xenproject.org>;
	Fri, 20 Feb 2015 09:29:55 -0800 (PST)
In-Reply-To: <1424448515.30924.334.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On 20/02/15 16:08, Ian Campbell wrote:
> On Wed, 2015-01-28 at 18:26 +0000, Stefano Stabellini wrote:
> 
>>> +        int spi = irq - 32;
>>
>> unsigned int
> 
> and underflow?

No because there is a check (irq < 32) before using the variable spi.
It was more convenient to initialize it directly.


Regards,

-- 
Julien Grall