From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbbBWM5G (ORCPT ); Mon, 23 Feb 2015 07:57:06 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:43568 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbbBWM5C (ORCPT ); Mon, 23 Feb 2015 07:57:02 -0500 Message-ID: <54EB2399.5090500@de.ibm.com> Date: Mon, 23 Feb 2015 13:56:57 +0100 From: Christian Borntraeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alexander Graf , Michael Mueller CC: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gleb Natapov , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com> <54E73C8F.7000202@suse.de> <20150220160046.4743acc8@bee> <89E3550E-9E2B-4D95-A809-B7C64EBCD7C5@suse.de> In-Reply-To: <89E3550E-9E2B-4D95-A809-B7C64EBCD7C5@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022312-0017-0000-0000-00000320743C Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 20.02.2015 um 16:22 schrieb Alexander Graf: > > > >> Am 20.02.2015 um 16:00 schrieb Michael Mueller : >> >> On Fri, 20 Feb 2015 14:54:23 +0100 >> Alexander Graf wrote: >> >>>> >>>> +/* machine related properties */ >>>> +typedef struct S390CPUMachineProps { >>>> + uint16_t class; /* machine class */ >>>> + uint16_t ga; /* availability number of machine */ >>>> + uint16_t order; /* order of availability */ >>>> +} S390CPUMachineProps; >>>> + >>>> +/* processor related properties */ >>>> +typedef struct S390CPUProcessorProps { >>>> + uint16_t gen; /* S390 CMOS generation */ >>>> + uint16_t ver; /* version of processor */ >>>> + uint32_t id; /* processor identification*/ >>>> + uint16_t type; /* machine type */ >>>> + uint16_t ibc; /* IBC value */ >>>> + uint64_t *fac_list; /* list of facilities */ >>> >>> Just make this uint64_t fac_list[2]. That way we don't have to track any >>> messy allocations. >> >> It will be something like "uint64_t fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB not >> just 16 bytes but I will change it. > > Why? Do we actually need that many? This is a qemu internal struct. The kernel already enabled the 3rd word for z13 support, https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?id=f8b2dcbd9e6d1479b9b5a9e9e78bbaf783bde819 so make it at least 3. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPsZQ-00019z-41 for qemu-devel@nongnu.org; Mon, 23 Feb 2015 07:57:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPsZM-0007ml-Uk for qemu-devel@nongnu.org; Mon, 23 Feb 2015 07:57:08 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:48037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPsZM-0007mG-LU for qemu-devel@nongnu.org; Mon, 23 Feb 2015 07:57:04 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Feb 2015 12:57:01 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id CD8521B08069 for ; Mon, 23 Feb 2015 12:57:12 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1NCuwDl10355180 for ; Mon, 23 Feb 2015 12:56:58 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1N7qMOf022718 for ; Mon, 23 Feb 2015 02:52:22 -0500 Message-ID: <54EB2399.5090500@de.ibm.com> Date: Mon, 23 Feb 2015 13:56:57 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com> <54E73C8F.7000202@suse.de> <20150220160046.4743acc8@bee> <89E3550E-9E2B-4D95-A809-B7C64EBCD7C5@suse.de> In-Reply-To: <89E3550E-9E2B-4D95-A809-B7C64EBCD7C5@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Michael Mueller Cc: "linux-s390@vger.kernel.org" , "kvm@vger.kernel.org" , Gleb Natapov , "qemu-devel@nongnu.org" , "linux-kernel@vger.kernel.org" , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Am 20.02.2015 um 16:22 schrieb Alexander Graf: > > > >> Am 20.02.2015 um 16:00 schrieb Michael Mueller : >> >> On Fri, 20 Feb 2015 14:54:23 +0100 >> Alexander Graf wrote: >> >>>> >>>> +/* machine related properties */ >>>> +typedef struct S390CPUMachineProps { >>>> + uint16_t class; /* machine class */ >>>> + uint16_t ga; /* availability number of machine */ >>>> + uint16_t order; /* order of availability */ >>>> +} S390CPUMachineProps; >>>> + >>>> +/* processor related properties */ >>>> +typedef struct S390CPUProcessorProps { >>>> + uint16_t gen; /* S390 CMOS generation */ >>>> + uint16_t ver; /* version of processor */ >>>> + uint32_t id; /* processor identification*/ >>>> + uint16_t type; /* machine type */ >>>> + uint16_t ibc; /* IBC value */ >>>> + uint64_t *fac_list; /* list of facilities */ >>> >>> Just make this uint64_t fac_list[2]. That way we don't have to track any >>> messy allocations. >> >> It will be something like "uint64_t fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB not >> just 16 bytes but I will change it. > > Why? Do we actually need that many? This is a qemu internal struct. The kernel already enabled the 3rd word for z13 support, https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?id=f8b2dcbd9e6d1479b9b5a9e9e78bbaf783bde819 so make it at least 3.